fix: stop trying to sign pending txes when they are no longer non-locked - Githubissues

dashpay / dash

Dash - Reinventing Cryptocurrency

https://www.dash.org

MIT License

1.49k stars 1.2k forks source link

fix: stop trying to sign pending txes when they are no longer non-locked #6174

Closed UdjinM6 closed 2 months ago

UdjinM6 commented 2 months ago

Issue being fixed or feature implemented

Masternodes keep trying to sign txes they received initially even after these txes were replaced by is/chain-locked txes later.

What was done?

Remove entries from pendingRetryTxs when txes are removed from nonLockedTxs set (as either already locked or as conflicted, doesn't matter).

How Has This Been Tested?

Breaking Changes

Checklist:

[x] I have performed a self-review of my own code
[x] I have commented my code, particularly in hard-to-understand areas
[ ] I have added or updated relevant unit/integration/functional/e2e tests
[ ] I have made corresponding changes to the documentation
[x] I have assigned this pull request to a milestone (for repository code-owners and collaborators only)