guix: Default to building for some supported HOSTs only

dashpay / dash

Dash - Reinventing Cryptocurrency

https://www.dash.org

MIT License

1.49k stars 1.2k forks source link

guix: Default to building for some supported HOSTs only #6388

Closed UdjinM6 closed 1 week ago

UdjinM6 commented 2 weeks ago

Issue being fixed or feature implemented

https://github.com/dashpay/dash/pull/6382#discussion_r1833266383

What was done?

How Has This Been Tested?

Breaking Changes

Checklist:

[ ] I have performed a self-review of my own code
[ ] I have commented my code, particularly in hard-to-understand areas
[ ] I have added or updated relevant unit/integration/functional/e2e tests
[ ] I have made corresponding changes to the documentation
[ ] I have assigned this pull request to a milestone (for repository code-owners and collaborators only)

github-actions[bot] commented 2 weeks ago

This pull request has conflicts, please rebase.

PastaPastaPasta commented 2 weeks ago

I think I prefer this PRs approach. Sure it'll cause conflicts. But the conflicts will be very minimal / trivial to resolve. I prefer not needing to change my automation to run the guix-start instead.

UdjinM6 commented 1 week ago

I think I prefer this PRs approach. Sure it'll cause conflicts. But the conflicts will be very minimal / trivial to resolve. I prefer not needing to change my automation to run the guix-start instead.

Don't be lazy :P

Speaking seriously though, #6390 requires trivial changes in private build scripts - a removal of SDK download and a drop-in replacement for guix-build. This needs to be done only once and adds no technical debt to our public repo. It also aligns CI builds and our release process. I think I'm actually leaning more towards that solution now...

PastaPastaPasta commented 1 week ago

Reopen if desired?