refactor: adjust locking in signing_shares avoid needing one main RecursiveMutex and instead using smaller regular Mutexes - Githubissues

dashpay / dash

Dash - Reinventing Cryptocurrency

https://www.dash.org

MIT License

1.49k stars 1.2k forks source link

refactor: adjust locking in signing_shares avoid needing one main RecursiveMutex and instead using smaller regular Mutexes #6410

Closed PastaPastaPasta closed 5 days ago

PastaPastaPasta commented 6 days ago

What was done?

Refactor the locking / mutex usage in signing_shares to focus on smaller scopes / avoid recursive mutex

How Has This Been Tested?

Ran functional tests lots of times with tsan / enable-debug

Breaking Changes

None

Checklist:

[x] I have performed a self-review of my own code
[ ] I have commented my code, particularly in hard-to-understand areas
[ ] I have added or updated relevant unit/integration/functional/e2e tests
[ ] I have made corresponding changes to the documentation
[x] I have assigned this pull request to a milestone (for repository code-owners and collaborators only)

PastaPastaPasta commented 6 days ago

feature_llmq_rotation.py failed in tsan CI; gonna run that locally a bit.