[GUI] Send Tab PrivateSend/InstantSend Check Boxes to Dark - Githubissues

dashpay / dash

Dash - Reinventing Cryptocurrency

https://www.dash.org

MIT License

1.49k stars 1.2k forks source link

[GUI] Send Tab PrivateSend/InstantSend Check Boxes to Dark #826

Closed bertronburbaron closed 7 years ago

bertronburbaron commented 8 years ago

The privatesend and instantsend check boxes on the send tab are too dark. The contrast between the black background and the green check mark is very bad. I would suggest changing the black background to some other color or changing the green check mark to white or a lighter color.

screenshot from 2016-05-29 11-08-32

I've tested this on 4 different computer screens and they are all very hard to see.

schinzelh commented 8 years ago

ping @crowning-

crowning- commented 8 years ago

I'll have a look tomorrow, thanks for pinging :-)

Edit: @cassidysummers , which Linux distribution are you using here? On Ubuntu (with Unity desktop) it looks okay

bertronburbaron commented 8 years ago

I'm using Ubuntu 16.04 (is unity default? that's what I'm using). It looks alright on my laptop screen, still a little bit fuzzy though, and on my external monitor it's really hard to see. Maybe my eyes are just getting bad. What color green is that arrow?

crowning- commented 8 years ago

If I remember correctly we don't set the the color, the color of the arrow+box depends on the desktop (not wallet!) theme you're using. Should be an easy fix once I can reproduce the problem.

crowning- commented 8 years ago

@schinzelh I installed an Ubuntu 16.04 testbox and found some things we need to address:

Ubuntu 14.04 built binaries don't run on Ubuntu 16.04 because 14.04 uses boost 1.54, 16.06 uses boost 1.58. And the other way around is also a problem. This should be noted in the build-documentation. (I can do this)
There are no 1.58 packages for Ubuntu 14.04, and no 1.54 packages for Ubuntu 16.06, so a 'normal' end-user won't be able to run dash-qt if the build was done on the 'other' system.
The issue mentioned by @cassidysummers, even when not related to boost, disappears when you run a Ubuntu 16.04/boost 1.58 built wallet.

I wouldn't want build version-dependent Linux binaries, but right now I don't see an easy way around this. What do you think? Static linking?

schinzelh commented 8 years ago

@crowning- Hmm, did you test Bitcoin as well? Do they have the same issue?

crowning- commented 8 years ago

Will try...

crowning- commented 8 years ago

So, I built Bitcoin (master-branch) on Ubuntu 14.04 and 16.04 and it has the BOOST version issues as well.

Not the checkbox issues, though, but our traditional (sans-CSS) wallet doesn't has them either.

Maybe it's easiest to open an issue there :smirk:

crowning- commented 8 years ago

...on a second thought, our Gitian build runs on BOTH Ubuntus (minus the checkbox issue).

Do you know where the build scripts differ?

schinzelh commented 8 years ago

Not sure what you mean with "runs on both"? You mean our gitian builds are compatible with Ubuntu 14.04 and 16.04, while the Bitcoin binaries from bitcoin.org/downloads are not?

crowning- commented 8 years ago

The Dash + Bitcoin Gitian builds run fine on both Ubuntus, but the Dash-build has the checkbox-issue in the non-Qt (aka CSS) themes on Ubuntu 16.04. I could fix the CSS-issue.

The Dash + Bitcoin native builds complain about the wrong BOOST version, but when given the correct BOOST dynamic (= *.so) library for each Ubuntu version they will run fine, and for the Dash-CSS-themes the checkboxes look okay.

From my point of view the native builds shouldn't complain about a wrong dynamic library.

crowning- commented 8 years ago

Never mind, native builds are supposed to by dynamically build.

To be back on topic, I know the reason for the dark labels and will fix it later today or tomorrow.

crowning- commented 8 years ago

Status summary:

there's no easy fix in CSS (that I know of) which works for all of our checkbox+background combinations AND looks good.
it's not clear whether Qt or Ubuntu 16.04 is the problem.
even if we should find some CSS-magic to solve this we could face the same problem again when the next update of OS (Ubuntu, Debian, SuSE, Redhat, etc.) times desktop (Gnome, Unity, KDE, etc.) times available desktop themes/color-schemes is available.
the behavior is different for native (dynamically linked) Dash builds and static builds via Gitian, so we would have to test both each time we change something. That's a serious PITA. I know because I did exactly this during the last days.

My conclusion:

the simplest way to work around all those future problems would be to use our own images for checked/unchecked checkboxes. We did this already for the scrollbar-arrows (see https://github.com/dashpay/dash/tree/v0.12.1.x/src/qt/res/images/light), so we could do this easily for checkboxes as well, it's no big deal via CSS.

The only disadvantage I see is that we won't always have the latest blinky look of the underlying OS. OTOH this could also be an advantage :-)

At this point (and if nobody complains) I'd like to hand over to our trusted masters of beautiful image design @snogcel and @salmion . If you 2 should need help integrating/testing the new images into the Gitian build process we should coordinate this over at slack.

schinzelh commented 8 years ago

@crowning- agree, there is no easy fix for this and it is an issue which we share with many multi OS softwares.

Having all images rendered out and not rely on underlying OS theme is ok for me.

UdjinM6 commented 8 years ago

@cassidysummers this should be fixed by #868, pls verify using test builds https://www.dash.org/forum/threads/v12-1-testnet-launch-thread.9014/page-18#post-96308 Thanks!