search

dashpay / dips

Dash Improvement Proposals
https://docs.dash.org/projects/core/en/stable/docs/dips/README.html
MIT License
73 stars 56 forks source link

AssetLockTx is missing from the DIP 2 table #155

Open coolaj86 opened 3 weeks ago

coolaj86 commented 3 weeks ago

The Asset Lock transaction is a DIP2-based special transaction that gives Platform the information to assign credits to identities. - https://docs.dash.org/projects/core/en/stable/docs/reference/transactions-special-transactions.html#

Not here: https://github.com/dashpay/dips/blob/master/dip-0002/special-transactions.md

coolaj86 commented 3 weeks ago

It appears that the documentation for the Asset Lock Payload has not been created.

DIP-11 mentions it, but seems to be referring to the Transition, NOT the Transaction.

knst commented 3 weeks ago

It appears that the documentation for the Asset Lock Payload has not been created.

Please look to this PR: https://github.com/dashpay/dips/pull/152 That's not the final version yet, but it is very close to the final version.

The information that you are looking is here:

The Asset Lock transaction (AssetLockTx) is a DIP-2-based special transaction that gives Platform the information required to assign credits to Identities. This special transaction is type 8. https://github.com/dashpay/dips/pull/152/files#diff-76641516cacd59ffc5aa637b138f3fddb72ba40ba55e30e99ae2e23cac9efcb0R71

coolaj86 commented 3 weeks ago

Update:

It appears that the script of the Asset Lock is just a normal TxOut pkhScript.

I haven't been able to verify yet, but I believe that the TxForSig representation includes the normal tx, then the "extra payload", then sighashtype. It's conceivable that it's the normal signable tx with the sighashtype, and then the "extra payload"... but I don't think that will show to be the case.

The most complete partial documentation is here: https://docs.dash.org/projects/core/en/stable/docs/reference/transactions-special-transactions.html#assetlocktx