dashpay / electrum-dash-old

Electrum-DASH - a Dash thin client
https://electrum-dash.org
MIT License
37 stars 114 forks source link

Exception in thread: masternode_manager.py #27

Closed splawik21 closed 8 years ago

splawik21 commented 8 years ago

During the testing on windows build 0c32e9c I noticed some freeze moments and got this in the debug window. electrum1

schinzelh commented 8 years ago

ping @Kefkius

Kefkius commented 8 years ago

I've also gotten this. It happens when you use an Electrum-DASH server which doesn't support the latest masternode functionality.

Freeze moments shouldn't be a result though.

Edit: This appears to be an issue with versions of dashd. Some versions use "FeeHash" as a dictionary key and some use "FeeTXHash". It's not a difficult thing to fix, but I'm wondering how many other discrepancies there are between versions.

schinzelh commented 8 years ago

Can we catch the exception and tell the user he is connected to a "wrong" (not Trezor capable) server?

Re. dashd versions: I am afraid there may be some more changes in 12.1 client. Maybe @UdjinM6 can diff them out?

Kefkius commented 8 years ago

I've been able to reproduce the error and fix it with #29

@schinzelh It's not necessarily a "wrong" server, it's just a change in the format of the proposals list.

schinzelh commented 8 years ago

Cool, building a new version and waiting for @splawik21 to test

@Kefkius got it :)

Kefkius commented 8 years ago

@schinzelh Alright. About the report of freezing: My best guess is that the user is running Electrum-DASH in a VM or with a CPU that has limited threading capabilities. If that is the case, then a similar "freezing" should happen during transaction signing and broadcasting.

splawik21 commented 8 years ago

@Kefkius nope, no freezing with the new version, this is not a VM and is a good hardware too. Please check my latest issue https://github.com/dashpay/electrum-dash/issues/30

schinzelh commented 8 years ago

It seems this has been resolved by proper exception handling, can the ticket be closed?