dashpay / insight-ui

A Dash blockchain web browser user interface
26 stars 67 forks source link

Transaction - Displaying a wrong transaction do not warn us #55

Open Alex-Werner opened 5 years ago

Alex-Werner commented 5 years ago

If we decide to look up for a random non-existant transaction (/insight/tx/0000000001219cb882504216cb0b89de6567483e7a6a3bce45026b26fca9ff17 for instance), we do not have anything warning us about it.

We are only left with this : image

There is a flashMessage that is being triggered in the Transaction.get method that seems to not be displayed. Which seems to be linked to the logic being broken, it appears that many method such as Transaction.get(), expect failureCallback to be called on exception such as a status page being 404. What really happens is that it goes into the successCallback that do not expect thoses and fails.

Some investigation is needed.