dashpay / p2pool-dash

GNU General Public License v3.0
48 stars 85 forks source link

p2pool is not starting with dash v18.0.1 #79

Closed 2acoin closed 1 year ago

2acoin commented 1 year ago

After upgrading to dash v18.0.1 our p2pool instance is no longer able to start. We get to this point in the startup at which it just hangs

2022-09-14 17:15:31.386600 p2pool (version 13.0.0-9-ga360927) 2022-09-14 17:15:31.386738 2022-09-14 17:15:31.386851 Testing dashd RPC connection to 'http://127.0.0.1:9998/' with username 'dashrpcuser'... 2022-09-14 17:15:31.513816 ...success! 2022-09-14 17:15:31.513914 Current block hash: 222f2b675ad8ab40eb09ef1b69ea45c986329b9be794472c18 2022-09-14 17:15:31.513954 Current block height: 1738349 2022-09-14 17:15:31.513981 2022-09-14 17:15:31.514018 Testing dashd P2P connection to '127.0.0.1:9999'... 2022-09-14 17:15:36.514230 ...taking a while. Common reasons for this include all of dashd's connection slots being used... Any ideas on what we need to change so that p2pool is compatible with dash v18.0.1?

kxcd commented 1 year ago

I am facing the same issue, it seems the pool is not updated to reflect the changes of v18.

p2poolmining commented 1 year ago

From what I can see, it appears that the P2P connection version has been updated. https://github.com/dashpay/p2pool-dash/blob/master/p2pool/dash/p2p.py That change along with more seems to have stopped P2Pool-Dash from working with v18.0.1

UdjinM6 commented 1 year ago

Guys, can you test https://github.com/dashpay/p2pool-dash/pull/80 pls?

p2poolmining commented 1 year ago

We have the recommended changes installed on our pools https://www.p2poolmining.us/mining-pools/

And everything seems to be working as expected!