dashpay / platform

L2 solution for seriously fast decentralized applications for the Dash network
https://dashplatform.readme.io/docs/introduction-what-is-dash-platform
MIT License
67 stars 39 forks source link

Bug (Dashmate) not fetching latest Dash Core v19.3.0 (docker image dashpay/dashd:19.3.0) #1281

Closed qwizzie closed 1 year ago

qwizzie commented 1 year ago

Provide a general summary of the issue in the Title above

After Pasta released Dash Core v19.3.0 on Mainnet yesterday, i expected to just update using Dashmate. But it seems after issuing commands

npm update -g dashmate dashmate update

that Dashmate has not been updated by devs to fetch latest Dash Core v19.3.0 (it is still fetching v19.2.0 and considers that as 'up to date')

Tell us what should happen

Dashmate should have no problems updating to latest Dash Core version 19.3.0 on Mainnet

Current Behavior Dashmate has a problem currently updating to latest Dash Core version 19.3.0 on Mainnet

Possible Solution change image path to dashpay/dashd:19.3.0 and push a new dashmate version release or maybe even better to prevent this from happening again in the future change image path to dashpay/dashd:latest ? i assume both mainnet and testnet image paths in Dashmate need to be updated

Also please provide documentation to Dashmate users on how to change this manually on Github (https://github.com/dashpay/platform/blob/master/packages/dashmate/README.md). I understand there is a specific command available to change this (dashmate config set .. something ? i forgot the exact command )

Update : found it --> dashmate config set core.docker.image dashpay/dashd:19.3.0 or dashmate config set core.docker.image dashpay/dashd:latest

Steps to Reproduce (for bugs) npm update -g dashmate dashmate update

See also : https://www.dash.org/forum/index.php?threads/v19-3-0-release-announcement.53942/#post-235605 (and read the off topic part there too, relates to some other unrelated bugs)

qwizzie commented 1 year ago

Looks like Dashmate has been updated to fetch Docker Image : dashpay/dashd:19.3.0 See : https://github.com/dashpay/platform/commit/f75b036ae07b977f0e848c2f0501ae0b9d787798 So i will close this one.