DAPI: Calls to `getTransaction` only valid if wallet is loaded

dashpay / platform

L2 solution for seriously fast decentralized applications for the Dash network

https://dashplatform.readme.io/docs/introduction-what-is-dash-platform

MIT License

72 stars 39 forks source link

DAPI: Calls to `getTransaction` only valid if wallet is loaded #1440

Closed kxcd closed 1 month ago

kxcd commented 1 year ago

https://github.com/dashpay/platform/blob/ed354ca52969676f8231765fc04bbe02b1d9ba25/packages/dapi/lib/externalApis/dashcore/rpc.js#L174-L193

Where is is this getting called? A masternode does not have an attached wallet, so calling this on an MN will return the empty set and an error. IMO these two methods should be removed.

shumkov commented 1 month ago

Hello. Thank you for your report. This function is not used. It will be removed when we refactor DAPI.