Closed QuantumExplorer closed 6 days ago
[!WARNING]
Rate limit exceeded
@QuantumExplorer has exceeded the limit for the number of commits or files that can be reviewed per hour. Please wait 4 minutes and 41 seconds before requesting another review.
β How to resolve this issue?
After the wait time has elapsed, a review can be triggered using the `@coderabbitai review` command as a PR comment. Alternatively, push new commits to this PR. We recommend that you space out your commits to avoid hitting the rate limit.π¦ How do rate limits work?
CodeRabbit enforces hourly rate limits for each developer per organization. Our paid plans have higher rate limits than the trial, open-source and free plans. In all cases, we re-allow further reviews after a brief timeout. Please see our [FAQ](https://coderabbit.ai/docs/faq) for further information.π₯ Commits
Files that changed from the base of the PR and between f57a0b3dd54c90f38b09d54994f52e5a97d49183 and 9e17bae4e0bb8e1ba7659f871f2aabe7746aba6e.
The changes introduce several new features and modifications to existing structures within the codebase. A new variant, PerformNetworkThresholdSigning
, is added to the ValidationOperation
enum, enhancing fee calculation for network threshold signing operations. Additionally, a new trait for validating identity credit transfers is introduced, improving balance checks. Method signatures across various modules are updated to include an execution_context
, allowing for more integrated state transition handling. Fee structures are also modified, particularly for credit withdrawals, reflecting significant cost adjustments.
File Path | Change Summary |
---|---|
packages/rs-drive-abci/src/execution/types/execution_operation/mod.rs |
Added PerformNetworkThresholdSigning variant to ValidationOperation enum and updated fee calculation logic. |
packages/rs-drive-abci/src/execution/validation/state_transition/state_transitions/identity_credit_withdrawal/balance/v0/mod.rs |
Introduced IdentityCreditTransferTransitionBalanceValidationV0 trait with a new balance validation method. |
packages/rs-drive-abci/src/execution/validation/state_transition/state_transitions/identity_credit_withdrawal/mod.rs |
Updated method signatures in IdentityCreditWithdrawalTransition to include execution_context . |
packages/rs-drive-abci/src/execution/validation/state_transition/state_transitions/identity_credit_withdrawal/state/v0/mod.rs |
Modified validate_state_v0 and transform_into_action_v0 methods to include execution_context . |
packages/rs-platform-version/src/version/fee/mod.rs |
Updated FeeProcessingVersion struct, added perform_network_threshold_signing , and modified existing fields. |
packages/rs-platform-version/src/version/fee/processing/mod.rs |
Added perform_network_threshold_signing field to FeeProcessingVersion struct. |
packages/rs-platform-version/src/version/fee/processing/v1.rs |
Introduced constant perform_network_threshold_signing with a value of 100000000 . |
packages/rs-platform-version/src/version/fee/state_transition_min_fees/v1.rs |
Updated credit_withdrawal fee value from 100000 to 400000000 . |
π° In fields of code where rabbits play,
New features hop in, brightening the day!
With fees adjusted and checks so fine,
Our system's ready, it's truly divine!
So letβs celebrate with a joyful cheer,
For every change brings us closer, my dear! π₯
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?
Issue being fixed or feature implemented
This PR addresses the need to better match withdrawal fees to the actual processing costs, ensuring that fees reflect the workload incurred by the platform when processing withdrawals. It solves discrepancies between the previously estimated fees and the actual cost incurred during the withdrawal process, leading to a more accurate and fair fee calculation.
What was done?
Added a fee of around 2.5 cents at a Dash price of 25$ for withdrawals.
How Has This Been Tested?
Needs testing on Testnet, not yet tested.
Breaking Changes
Since fees change it is is a breaking change that will take effect in v4 of the protocol.
Checklist:
For repository code-owners and collaborators only
Summary by CodeRabbit
New Features
Bug Fixes
Documentation
Refactor