dashpay / platform

L2 solution for seriously fast decentralized applications for the Dash network
https://dashplatform.readme.io/docs/introduction-what-is-dash-platform
MIT License
70 stars 40 forks source link

feat(platform)!: matched withdrawal fees to actual processing cost #2186

Closed QuantumExplorer closed 6 days ago

QuantumExplorer commented 6 days ago

Issue being fixed or feature implemented

This PR addresses the need to better match withdrawal fees to the actual processing costs, ensuring that fees reflect the workload incurred by the platform when processing withdrawals. It solves discrepancies between the previously estimated fees and the actual cost incurred during the withdrawal process, leading to a more accurate and fair fee calculation.

What was done?

Added a fee of around 2.5 cents at a Dash price of 25$ for withdrawals.

How Has This Been Tested?

Needs testing on Testnet, not yet tested.

Breaking Changes

Since fees change it is is a breaking change that will take effect in v4 of the protocol.

Checklist:

For repository code-owners and collaborators only

Summary by CodeRabbit

coderabbitai[bot] commented 6 days ago

[!WARNING]

Rate limit exceeded

@QuantumExplorer has exceeded the limit for the number of commits or files that can be reviewed per hour. Please wait 4 minutes and 41 seconds before requesting another review.

βŒ› How to resolve this issue? After the wait time has elapsed, a review can be triggered using the `@coderabbitai review` command as a PR comment. Alternatively, push new commits to this PR. We recommend that you space out your commits to avoid hitting the rate limit.
🚦 How do rate limits work? CodeRabbit enforces hourly rate limits for each developer per organization. Our paid plans have higher rate limits than the trial, open-source and free plans. In all cases, we re-allow further reviews after a brief timeout. Please see our [FAQ](https://coderabbit.ai/docs/faq) for further information.
πŸ“₯ Commits Files that changed from the base of the PR and between f57a0b3dd54c90f38b09d54994f52e5a97d49183 and 9e17bae4e0bb8e1ba7659f871f2aabe7746aba6e.

Walkthrough

The changes introduce several new features and modifications to existing structures within the codebase. A new variant, PerformNetworkThresholdSigning, is added to the ValidationOperation enum, enhancing fee calculation for network threshold signing operations. Additionally, a new trait for validating identity credit transfers is introduced, improving balance checks. Method signatures across various modules are updated to include an execution_context, allowing for more integrated state transition handling. Fee structures are also modified, particularly for credit withdrawals, reflecting significant cost adjustments.

Changes

File Path Change Summary
packages/rs-drive-abci/src/execution/types/execution_operation/mod.rs Added PerformNetworkThresholdSigning variant to ValidationOperation enum and updated fee calculation logic.
packages/rs-drive-abci/src/execution/validation/state_transition/state_transitions/identity_credit_withdrawal/balance/v0/mod.rs Introduced IdentityCreditTransferTransitionBalanceValidationV0 trait with a new balance validation method.
packages/rs-drive-abci/src/execution/validation/state_transition/state_transitions/identity_credit_withdrawal/mod.rs Updated method signatures in IdentityCreditWithdrawalTransition to include execution_context.
packages/rs-drive-abci/src/execution/validation/state_transition/state_transitions/identity_credit_withdrawal/state/v0/mod.rs Modified validate_state_v0 and transform_into_action_v0 methods to include execution_context.
packages/rs-platform-version/src/version/fee/mod.rs Updated FeeProcessingVersion struct, added perform_network_threshold_signing, and modified existing fields.
packages/rs-platform-version/src/version/fee/processing/mod.rs Added perform_network_threshold_signing field to FeeProcessingVersion struct.
packages/rs-platform-version/src/version/fee/processing/v1.rs Introduced constant perform_network_threshold_signing with a value of 100000000.
packages/rs-platform-version/src/version/fee/state_transition_min_fees/v1.rs Updated credit_withdrawal fee value from 100000 to 400000000.

Suggested reviewers

🐰 In fields of code where rabbits play,
New features hop in, brightening the day!
With fees adjusted and checks so fine,
Our system's ready, it's truly divine!
So let’s celebrate with a joyful cheer,
For every change brings us closer, my dear! πŸ₯•


Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❀️ Share - [X](https://twitter.com/intent/tweet?text=I%20just%20used%20%40coderabbitai%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20the%20proprietary%20code.%20Check%20it%20out%3A&url=https%3A//coderabbit.ai) - [Mastodon](https://mastodon.social/share?text=I%20just%20used%20%40coderabbitai%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20the%20proprietary%20code.%20Check%20it%20out%3A%20https%3A%2F%2Fcoderabbit.ai) - [Reddit](https://www.reddit.com/submit?title=Great%20tool%20for%20code%20review%20-%20CodeRabbit&text=I%20just%20used%20CodeRabbit%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20proprietary%20code.%20Check%20it%20out%3A%20https%3A//coderabbit.ai) - [LinkedIn](https://www.linkedin.com/sharing/share-offsite/?url=https%3A%2F%2Fcoderabbit.ai&mini=true&title=Great%20tool%20for%20code%20review%20-%20CodeRabbit&summary=I%20just%20used%20CodeRabbit%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20proprietary%20code)
πŸͺ§ Tips ### Chat There are 3 ways to chat with [CodeRabbit](https://coderabbit.ai): - Review comments: Directly reply to a review comment made by CodeRabbit. Example: - `I pushed a fix in commit , please review it.` - `Generate unit testing code for this file.` - `Open a follow-up GitHub issue for this discussion.` - Files and specific lines of code (under the "Files changed" tab): Tag `@coderabbitai` in a new review comment at the desired location with your query. Examples: - `@coderabbitai generate unit testing code for this file.` - `@coderabbitai modularize this function.` - PR comments: Tag `@coderabbitai` in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples: - `@coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.` - `@coderabbitai read src/utils.ts and generate unit testing code.` - `@coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.` - `@coderabbitai help me debug CodeRabbit configuration file.` Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. ### CodeRabbit Commands (Invoked using PR comments) - `@coderabbitai pause` to pause the reviews on a PR. - `@coderabbitai resume` to resume the paused reviews. - `@coderabbitai review` to trigger an incremental review. This is useful when automatic reviews are disabled for the repository. - `@coderabbitai full review` to do a full review from scratch and review all the files again. - `@coderabbitai summary` to regenerate the summary of the PR. - `@coderabbitai resolve` resolve all the CodeRabbit review comments. - `@coderabbitai configuration` to show the current CodeRabbit configuration for the repository. - `@coderabbitai help` to get help. ### Other keywords and placeholders - Add `@coderabbitai ignore` anywhere in the PR description to prevent this PR from being reviewed. - Add `@coderabbitai summary` to generate the high-level summary at a specific location in the PR description. - Add `@coderabbitai` anywhere in the PR title to generate the title automatically. ### CodeRabbit Configuration File (`.coderabbit.yaml`) - You can programmatically configure CodeRabbit by adding a `.coderabbit.yaml` file to the root of your repository. - Please see the [configuration documentation](https://docs.coderabbit.ai/guides/configure-coderabbit) for more information. - If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: `# yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json` ### Documentation and Community - Visit our [Documentation](https://coderabbit.ai/docs) for detailed information on how to use CodeRabbit. - Join our [Discord Community](http://discord.gg/coderabbit) to get help, request features, and share feedback. - Follow us on [X/Twitter](https://twitter.com/coderabbitai) for updates and announcements.