Closed shumkov closed 4 days ago
The changes in this pull request enhance the functionality and clarity of withdrawal transaction handling within the codebase. Key updates include the introduction of a new struct for withdrawal limit information, the enhancement of withdrawal processing methods to incorporate metrics, and adjustments to existing method signatures to reflect these changes. Overall, the modifications provide more detailed insights into withdrawal limits while refining the control flow for processing withdrawal transactions.
File Path | Change Summary |
---|---|
packages/rs-drive-abci/src/execution/platform_events/withdrawals/pool_withdrawals_into_transactions_queue/v1/mod.rs |
Enhanced logic in pool_withdrawals_into_transactions_queue_v1 to manage withdrawal limits and integrate Prometheus metrics for tracking available and total limits. Updated comments for clarity on document processing. |
packages/rs-drive/src/drive/identity/withdrawals/calculate_current_withdrawal_limit/mod.rs |
Introduced WithdrawalLimitInfo struct to encapsulate daily withdrawal limits. Modified calculate_current_withdrawal_limit method to return WithdrawalLimitInfo instead of just credits, enhancing the information provided. |
🐰 In the meadow where bunnies play,
New limits and metrics brighten the day.
With withdrawals now clear and bright,
Transactions flow with pure delight!
Hooray for the changes, let’s hop and cheer,
For a smoother journey, year after year! 🌼✨
Issue being fixed or feature implemented
To test withdrawal limits we need some additional visibility on the withdrawal logic
What was done?
How Has This Been Tested?
None
Breaking Changes
None
Checklist:
For repository code-owners and collaborators only
Summary by CodeRabbit
New Features
WithdrawalLimitInfo
struct to provide detailed withdrawal limit information.Bug Fixes
Documentation