fix(sdk)!: create channel error due to empty address

[shumkov]

Issue being fixed or feature implemented

New SDK 1.5.1 fails on android with:

rs_dapi_client::dapi_client: request failed error=ExecutionError { inner: Transport(Grpc(Status { code: FailedPrecondition, message: "Channel creation failed: transport error", source: None })), retries: 0, address: Some(Address { ban_count: 0, banned_until: None, uri: https://52.13.132.146:1443/ }) }

What was done?

• Do not allow to create invalid Address
• Return invalid argument instead of failed precondition in TransportClient::new_with_uri
• AddressList::add_uri is deprecated

How Has This Been Tested?

Running tests

Breaking Changes

• From<Uri> for Address replaced with TryFrom<Uri> for Address
• From<&str> for AddressList replaced with FromStr for AddressList
• FromIterator<Uri> for AddressList replaced with FromIterator<Address> for AddressList

Checklist:

• [x] I have performed a self-review of my own code
• [x] I have commented my code, particularly in hard-to-understand areas
• [x] I have added or updated relevant unit/integration/functional/e2e tests
• [x] I have added "!" to the title and described breaking changes in the corresponding section if my code contains any
• [x] I have made corresponding changes to the documentation if needed

For repository code-owners and collaborators only

• [x] I have assigned this pull request to a milestone

Summary by CodeRabbit

Release Notes

• New Features

  • Enhanced error handling for address parsing and gRPC channel creation.
  • Transitioned from URI strings to a structured Address type for improved type safety.

• Bug Fixes

  • Improved error reporting for address-related operations and retry mechanisms.

• Documentation

  • Updated examples and comments to reflect the new Address type usage.

• Tests

  • Refined test cases to align with the new address handling and error management.

[coderabbitai[bot]]

Walkthrough

The changes in this pull request primarily focus on enhancing the Address and AddressList structures within the rs-dapi-client module. Key modifications include transitioning from From to TryFrom for Address, updating error handling to improve clarity, and refining the conversion processes. The EvoNode struct and related test cases have also been adapted to utilize the new Address type. Additionally, adjustments in the gRPC transport layer have altered error reporting formats. Overall, these changes improve type safety and error handling across the affected components.

Changes

File Path	Change Summary
packages/rs-dapi-client/src/address_list.rs	- Modified FromStr implementation for Address to TryFrom<Uri> with improved error handling. - Updated FromStr for AddressList to parse Address instead of Uri. - Changed InvalidAddressUri to accept String. - Updated from_iter method to accept Address.
packages/rs-dapi-client/src/transport/grpc.rs	- Changed error handling in with_uri and with_uri_and_settings methods from failed_precondition to invalid_argument. - Updated error message formatting.
packages/rs-sdk/examples/read_contract.rs	- Updated import statement to include Address. - Changed URI construction to use Address directly instead of http::Uri.
packages/rs-sdk/src/platform/types/evonode.rs	- Updated example usage to instantiate EvoNode with Address instead of http::Uri.
packages/rs-sdk/src/sync.rs	- Expanded AsyncError enum to include Generic(String). - Updated logic in block_on and retry functions for improved error handling and retry mechanisms.
packages/rs-sdk/tests/fetch/config.rs	- Updated import statement to include Address. - Changed variable type from String to Address in address_list method.
packages/rs-sdk/tests/fetch/evonode.rs	- Updated tests to replace http::Uri with Address. - Modified error handling in tests to reflect the change to Address.

Possibly related PRs

• #2139: Related changes in the Address and AddressList structures, affecting how addresses are handled.
• #2200: Updates to the AddressList struct, directly related to the changes in the main PR.
• #2207: Involves modifications to the AddressList struct, relevant to the main PR's changes.
• #2223: Introduces a new public method in DapiClient that returns a reference to the address_list, related to the main PR.
• #2232: Modifications regarding the context provider, indirectly relating to the usage of Address and AddressList.
• #2278: Introduction of AddressListError type, enhancing error handling related to address list operations, aligning with the main PR's changes.

Suggested labels

rs-sdk, enhancement

Suggested reviewers

• QuantumExplorer
• lklimek

🐰 In the land of code where rabbits play,
New structures hop in, brightening the day.
From strings to addresses, we leap with delight,
Error handling's clearer, everything feels right!
With each little change, our code's a bit spry,
A hop and a skip, watch our features fly! 🐇✨

---

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share

- [X](https://twitter.com/intent/tweet?text=I%20just%20used%20%40coderabbitai%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20the%20proprietary%20code.%20Check%20it%20out%3A&url=https%3A//coderabbit.ai) - [Mastodon](https://mastodon.social/share?text=I%20just%20used%20%40coderabbitai%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20the%20proprietary%20code.%20Check%20it%20out%3A%20https%3A%2F%2Fcoderabbit.ai) - [Reddit](https://www.reddit.com/submit?title=Great%20tool%20for%20code%20review%20-%20CodeRabbit&text=I%20just%20used%20CodeRabbit%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20proprietary%20code.%20Check%20it%20out%3A%20https%3A//coderabbit.ai) - [LinkedIn](https://www.linkedin.com/sharing/share-offsite/?url=https%3A%2F%2Fcoderabbit.ai&mini=true&title=Great%20tool%20for%20code%20review%20-%20CodeRabbit&summary=I%20just%20used%20CodeRabbit%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20proprietary%20code)

🪧 Tips

### Chat There are 3 ways to chat with [CodeRabbit](https://coderabbit.ai): - Review comments: Directly reply to a review comment made by CodeRabbit. Example: - `I pushed a fix in commit , please review it.` - `Generate unit testing code for this file.` - `Open a follow-up GitHub issue for this discussion.` - Files and specific lines of code (under the "Files changed" tab): Tag `@coderabbitai` in a new review comment at the desired location with your query. Examples: - `@coderabbitai generate unit testing code for this file.` - `@coderabbitai modularize this function.` - PR comments: Tag `@coderabbitai` in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples: - `@coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.` - `@coderabbitai read src/utils.ts and generate unit testing code.` - `@coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.` - `@coderabbitai help me debug CodeRabbit configuration file.` Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. ### CodeRabbit Commands (Invoked using PR comments) - `@coderabbitai pause` to pause the reviews on a PR. - `@coderabbitai resume` to resume the paused reviews. - `@coderabbitai review` to trigger an incremental review. This is useful when automatic reviews are disabled for the repository. - `@coderabbitai full review` to do a full review from scratch and review all the files again. - `@coderabbitai summary` to regenerate the summary of the PR. - `@coderabbitai resolve` resolve all the CodeRabbit review comments. - `@coderabbitai configuration` to show the current CodeRabbit configuration for the repository. - `@coderabbitai help` to get help. ### Other keywords and placeholders - Add `@coderabbitai ignore` anywhere in the PR description to prevent this PR from being reviewed. - Add `@coderabbitai summary` to generate the high-level summary at a specific location in the PR description. - Add `@coderabbitai` anywhere in the PR title to generate the title automatically. ### CodeRabbit Configuration File (`.coderabbit.yaml`) - You can programmatically configure CodeRabbit by adding a `.coderabbit.yaml` file to the root of your repository. - Please see the [configuration documentation](https://docs.coderabbit.ai/guides/configure-coderabbit) for more information. - If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: `# yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json` ### Documentation and Community - Visit our [Documentation](https://coderabbit.ai/docs) for detailed information on how to use CodeRabbit. - Join our [Discord Community](http://discord.gg/coderabbit) to get help, request features, and share feedback. - Follow us on [X/Twitter](https://twitter.com/coderabbitai) for updates and announcements.