search

dashpay / platform

L2 solution for seriously fast decentralized applications for the Dash network
https://dashplatform.readme.io/docs/introduction-what-is-dash-platform
MIT License
72 stars 39 forks source link

Allow dashmate to bind Dash Core RPC on 0.0.0.0 #490

Closed pshenmic closed 1 year ago

pshenmic commented 2 years ago

Expected Behavior

You can bind Dash Core RPC, spinned up by dashmate and be able to fire requests from external networks

Current Behavior

Dash Core always binds to the loopback (127.0.0.1) and you can access it only from your local PC.

Possible Solution

Add a configuration key in the config that will default to 127.0.0.1, and user can configure any interface it wants. Pass that interface ip address into the docker-compose.yaml, by editing Core service port-forwarding section.

Alternatives Considered

Additional Context

thephez commented 2 years ago

Generally exposing Dash Core's RPC to external networks is discouraged for security reasons (https://bitcoin.stackexchange.com/a/88948, https://github.com/dashpay/dash/blob/master/doc/JSON-RPC-interface.md#security). For development/test environments it may be less of an issue, but imo dashmate should not offer the option to do so on mainnet.

pshenmic commented 1 year ago

Will not be implemented for security reasons

shumkov commented 1 year ago

Agree.