search

dashpay / proposal-generator

Dash Client-Side Governance Proposal Generator
https://proposal.dashevo.org/
15 stars 63 forks source link

start_epoch, end_epoch and payment_amount should be numbers, not strings #25

Closed UdjinM6 closed 6 years ago

Alex-Werner commented 6 years ago

Thank you for this one. Indeed by default jquery will always get a val() as string. Trivial fix here, will handle that ! Actually, If this is a constant rules, I should have that directly being handled in bitcore-lib-dash too then.

So you are confirming that start_epoch, end_epoch and payment_amount that aren't number should be rejected right ?

UdjinM6 commented 6 years ago

So you are confirming that start_epoch, end_epoch and payment_amount that aren't number should be rejected right ?

Yes, we are going to fix dashd validators and sentinel code the same way.

Alex-Werner commented 6 years ago

Good, then indeed I have to handle the validators in bitcore-lib then, because right now it still allow it. Handling that !

Thank you :)

chaeplin commented 6 years ago

fyi : 12.2 has gobject check <data-hex>. Can check a proposal without collateral submitting.

Alex-Werner commented 6 years ago

The problem here is that we are in a front place. So we can't use any check right now :/ I've implemented gobject list and get, but not check, it could be good to have that soon. In the meantime, we have a serialize check in bitcore-lib but it didn't take that into account