search

dashpay / proposal-generator

Dash Client-Side Governance Proposal Generator
https://proposal.dashevo.org/
15 stars 63 forks source link

Docker improvements #29

Closed jaydp17 closed 6 years ago

jaydp17 commented 6 years ago

Small build improvements using Docker.

1) It doesn't copy the node_modules from the host machine anymore Reason: we shouldn't trust the node_modules directory from outside, it's always better to let the node version that's inside the container download it's own.

2) Improves incremental build times, by not installing npm modules on every file change.

Let me know what your thoughts are on this. @nmarley @Alex-Werner

nmarley commented 6 years ago

Tested ACK

Thanks for this! +1 for optimization, and I agree we should be utilizing .dockerignore to reduce build context where possible, as well as copying the manitest/install early to avoid re-building with every code change.