UdjinM6
commented
2 years ago needs rebase
Closed thephez closed 2 years ago
UdjinM6
commented
2 years ago needs rebase
nmarley
commented
2 years ago I agree on the rebase.
Python 3.6 is no longer supported by Python for even security bugfixes anymore, so maybe we could just drop it altogether. The last security bugfix release was more than a year ago and the last regular bugfix release was almost 4 years ago.
PastaPastaPasta
commented
2 years ago Agree with dropping 3.6 support. Let's use all the new features. Straight to python 3.10!!
thephez
commented
2 years ago Rebased. We mention Ubuntu 18.04 in our README (still supported by Ubuntu). It uses Python 3.6 by default, so we may want to drop the 18.04 reference if we're not going to support Python 3.6. If we drop Python 3.6, I can consolidate this back into a single test with both Ubuntu versions in the matrix. Should I do that with this PR?
thephez
commented
2 years ago I think we should probably add 18.04 instead to make sure all supported configs are covered with tests (and btw Core still supports Ubuntu 16.04 if I'm not mistaken). Can be done in another PR so
Hmm, given the Python security issues mentioned by @nmarley and Ubuntu 18.04 going out of standard support within the next six months, I'm not sure that's necessary. Seems like we should be discouraging MNOs from running nodes on it - Dash deserves better than this!!!! :smile:
Going to merge this one, but we can continue discussion below...
Just a quick, possibly half-baked PR :see_no_evil: I noticed we hadn't added Ubuntu 22.04 testing back in once we solved the issue with Python 3.10 in #103 and figured I'd put something out there.
Python 3.6 fails on 22.04, so I added a second test job instead of just adding 22.04 to the matrix. Seems better to test what we can than to skip the OS entirely? Didn't investigate if we could make 3.6 work on 22.04 or not.