dashroshan / coding-contests-companion

💪 Discord bot for coding contests info, notifications, and daily problems from codechef, leetcode, hackerrank, codeforces, atcoder, hackerearth, and geeksforgeeks
MIT License
43 stars 40 forks source link

[GSSoC - 23] feat: Separating the functionality of Notification button to add delete roles. #34

Closed JatinSharma32 closed 1 year ago

JatinSharma32 commented 1 year ago

Issue

Hello, @roshan1337d first of all this bot is really amazing 😀, While exploring the features of coding-contests-companion bot, I found out that Role Addition & Role Removal functionality of the notification button in ./setup-contest.js can be separated and enhanced.

Current Behavior

Right now there is only one button present Notifications which does both role addition and removal tasks. So for a new Discord user, it's a little confusing as the follow up message is shown to the user after he presses the button.

Possible Solution

I have a solution for this task that will reduce the confusion of the user by adding one more button Stop Notifications.

Possible Implementation


:bulb: Tip: Please assign this issue to me, I will be glad to contribute to this amazing repository

dashroshan commented 1 year ago

That's a nice suggestion! Assigned this to you. Best of luck 🚀

JatinSharma32 commented 1 year ago

The PR is up and flying, Please have a look #42

I am open to feedbacks