search

dasi0075 / responsive-recipe-book

Taking the recipe book from your previous Typography class and turn it into a responsive website.
0 stars 0 forks source link

Problems with Favicon and Skip Links #2

Open dasi0075 opened 4 years ago

dasi0075 commented 4 years ago

Hi @thomasjbradley I have a question, I am almost passing with my recipe book in Markbot but I am having issues with my favicon and Skip Links (see screenshot attached). I followed the lesson with favicon and did everything accordingly, still not passing. Is there anything I am missing?

Screen Shot 2020-01-23 at 3 50 40 PM

Thank you

thomasjbradley commented 4 years ago

The favicons shouldn’t be inside the images folder—they should be out in the root project folder.

thomasjbradley commented 4 years ago

For the skip links, box-shadow requires more information, like:

box-shadow: 2px 2px 3px #fff;
dasi0075 commented 4 years ago

Thank you @thomasjbradley I will try those and if work I close the issue

dasi0075 commented 4 years ago

Hi @thomasjbradley Thank you the Favicon seems to have worked. Still having problems with the skip links though. Added the values you suggested but it won't accept. Also, I have another question: Greg wants us to add the proper font weigh to our fonts, he doesn't wants us to just add "bold" on our index. however, markbot is not accepting the way I added the font-weight. Can I add "700" inside my index? Thank you

dasi0075 commented 4 years ago

See samples of font-weight:

Screen Shot 2020-01-24 at 3 55 20 PM
thomasjbradley commented 4 years ago

In CSS bold means exactly the same thing as 700—so you don’t need to write 700.

The functionality error message at the bottom of Markbot isn’t related to skip links—it’s actual links. Markbot wants the actual links on your page, in the body copy, to have hover states.

dasi0075 commented 4 years ago

@thomasjbradley Would you mind talking to Greg about this because he mentioned that he will take points if we use "bold" instead of the actual weight.

Regarding the links I will try again, I am still a bit confused but will keep trying. Thank you

thomasjbradley commented 4 years ago

Yep.

dasi0075 commented 4 years ago

Hi @thomasjbradley I ran out of options here with the main-link. I researched and tried everything I could but I don't think I am fully understanding what is missing there. attached is the screenshot for you to see. That is the only thing left I assumed for my website to be done.

Screen Shot 2020-01-24 at 7 46 33 PM
thomasjbradley commented 4 years ago

I think it’s because, when you tab around on the recipe cards, nothing happens: when you hover they enlarge, but with keyboard access nothing changes.

Apply the same styles to :focus that you do to hover: https://github.com/dasi0075/responsive-recipe-book/blob/gh-pages/css/main.css#L146-L148

dasi0075 commented 4 years ago

@thomasjbradley hi there again, I tried and it's not working. I checked the cheat sheets again and tried to change the order on my HTML (nav first and main content after) but it didn't change anything. I may show you Tuesday in class if possible because probably its something small that I am missing. Thank you