dasilva333 / TowerGhostForDestiny

Tower Ghost for Destiny - This app allows you to transfer items between profiles, with various filters.
112 stars 42 forks source link

Fix for Song of Ir Yut and other items like it #115

Closed marmotpie closed 9 years ago

marmotpie commented 9 years ago

I'm using a Note 4 with Android 5.0.1. Every time I start the app, Hydra detects a new update; the version number shown in the About page displays 2.2.2 regardless of whether I select to ignore the update or install and restart. Three finger tapping the screen does not detect a new update. This issue has gone on for weeks, though it was manageable as I could avoid it by minimizing the app rather than closing it.

The second issue just started happening a few hours ago. In addition to having to sign in each time I open the app, only my vault and my hunter's items are displayed, while the blue loading bar persists. I let it try to load for 30 minutes, to no avail.

I have tried uninstalling and re-installing (both from the Play Store and manually from the download page here) multiple times, including clearing cached data and restarting my phone.The Chrome extension and Bungie's official app both still work for me.

weborican commented 9 years ago

I have seen both issues, but the issue with the loading not finishing just started happening yesterday. Loads my vault and my warlock, but stops at my Titan and Hunter. On the iPhone everything works fine, both running 2.2.2.

iPhone 6, running iOS 8.3 Nexus tablet, running Android 5.1

dasilva333 commented 9 years ago

@marmotpie

I'll mark this ticket as a bug and try to reproduce the issues tonight. thanks @weborican I'm glad it's working on your Android too

marmotpie commented 9 years ago

@dasilva333 Thanks for looking into it. I've tried it on different WiFi networks as well as on 4G/mobile, to the same result. This leads me to believe it is unlikely a network error from my end, though I suppose it could be my device (though I have restarted it multiple times).

Also, I think you may have misread, @weborican is having the same loading issue - he said it works correctly on his iPhone, not on his Android.

NoCodeLeftBehind commented 9 years ago

Latest 2.2.2 hangs at blue loading bar on Android. Works fine on iOS.

blackhawksq commented 9 years ago

I started getting the same problem this morning. It worked great last night, had an update this morning and now it will only show my titan. This is not a network problem. I'm using Galaxy s5

M3Rocket commented 9 years ago

Same here with me on both my Nexus 7 (2013) and Nexus 4. It started happening last night. It will only load one of my characters, but not the vault or the other two characters. Blue bar on the top stays. I've tried clearing cache, uninstall, reinstall. I don't think this is a network issue.

dasilva333 commented 9 years ago

Alright guys there's enough people having this problem that I don't think it's an isolated issue anymore, again I tested the latest version 2.2.2 on my Android device and it worked fine, I'll try it on my phone and tablet tonight and make necessary fixes. I also compared trunk to android and they are identical so I'm not sure what could be the cause. Thanks!

M3Rocket commented 9 years ago

I deleted the cache, data and uninstalled the Google Play downloaded version and hydrate-upgraded version. Then I sideloaded the 2.1.4 version from this repo (https://github.com/dasilva333/TowerGhostForDestiny/tree/div-movile-dist/), and declined the Hydrate update notice. This version seems to work.

I suspect Hydrate shenanigans.

dasilva333 commented 9 years ago

@M3Rocket I just uninstalled and reinstalled the app store version and let it update on the first prompt and it worked fine. I also just tried the one on my tablet also using the app store version just opened it and let it update and it worked fine.

So this apk goes out to @weborican @NoCodeLeftBehind @blackhawksq @marmotpie and @M3Rocket here's what I need you all to do now it's going to be tricky because you are all going to be sharing one session so if you see someone is currently using it don't try it too. Thanks

  1. install this debug apk: https://github.com/dasilva333/TowerGhostForDestiny/blob/div-movile-dist/TowerGhostforDestiny-debug-115.apk
  2. go to jsconsole.com
  3. type this in

    :listen C6781150-414A-4E02-8A48-B0B2A300DACF

  4. open the app and try to get it to crash or only load one character
  5. if a crash does happen it'll output something to the console just paste it in www.pastebin.com and report it here
weborican commented 9 years ago

My Nexus will not install that .apk, I get the "app not installed" message :-(

M3Rocket commented 9 years ago

I'm going to try the debug version right now.

ambrice commented 9 years ago

Also get the stuck loading bar. Will try the apk, in the mean time here's the adb logcat:

http://pastebin.com/raw.php?i=fRq7fPQ6

ambrice commented 9 years ago

On jsconsole I get the same uri malformed at app.js:828 error from adb logcat, and also:

file:///data/data/com.richardpinedo.towerghostfordestiny/files/downloads/app_dir/scripts/bungie.js:188 Uncaught TypeError: Cannot read property 'type' of undefined

M3Rocket commented 9 years ago

I'm also getting something similar like this: file:///data/data/com.richardpinedo.towerghostfordestiny/files/downloads/app_dir/js/app.js:828

Uncaught URIError: URI malformed

Connection established with file:///data/data/com.richardpinedo.towerghostfordestiny/files/downloads/app_dir/index.html Mozilla/5.0 (Linux; Android 5.1; Nexus 5 Build/LMY47D; wv) AppleWebKit/537.36 (KHTML, like Gecko) Version/4.0 Chrome/42.0.2311.129 Mobile Safari/537.36

ambrice commented 9 years ago

app.js:828 was apparently updated yesterday in commit 41e5a9f8b6e1c1ee357d70f1bd961d549ed8b81e "Fix for Song of Ir Yut". I don't have the Song but I do have the Fang..

dasilva333 commented 9 years ago

Thanks @M3Rocket I was trying to fix the encoding of the characters so they look right getting tired of seeing song of ir yacht. Anyhow I followed the some online advice and apparently there's problems between platforms, I couldn't even find references to Android and the technique used decodeURIComponent(escape anyways I backed out the change as part of 2.2.3 expect it soon and I'll rename this to Fix for Song of Ir Yut later.

NoCodeLeftBehind commented 9 years ago

I have both Song and Fang. I assume that commit was intended to fix the way the accented letter in Yut was being displayed. Perhaps that broke things for some devices depending on language or font being used... Can you please make a build without that commit to test that theory?

weborican commented 9 years ago

Bigo @NoCodeLeftBehind

If I move my Fang to my Titan, both my Hunter and Warlock now load and it gets stuck on loading my Titan.

ambrice commented 9 years ago

Can confirm. It wouldn't show my Vault until I moved my "Façade of the Hezen Lords" out of it, and wouldn't show my Titan until I moved my "Dämmerung FR5"

dasilva333 commented 9 years ago

Alright guys its part of master and android branch so look for 2.2.3 under About to make sure you have the fix

M3Rocket commented 9 years ago

Thanx for the quick fix @dasilva333 -- those pesky foreign characters. It bothers me too, but the Tower Ghost Android app not working altogether is worse. ;-)

Thanx @ambrice for the assist!

ambrice commented 9 years ago

Confirmed, 2.2.3 shows everything.

M3Rocket commented 9 years ago

Same here. 2.2.3 works now.

Also, I checked the names of Facade and Ir Yut on Android app, and it shows the proper accented characters.

weborican commented 9 years ago

All is well on Andriod once again! Thanks @dasilva333 for that super-quick fix!!!

dasilva333 commented 9 years ago

Hey guys I introduced a new fix for the Song of Ir Yut as of 2.3.0, can anyone test and confirm it's still working on their device? Thanks! @marmotpie @M3Rocket @NoCodeLeftBehind @blackhawksq @ambrice @weborican

matthubb commented 9 years ago

I have the Song. Displays and transfers fine on iOS.

dasilva333 commented 9 years ago

@matthubb ios wasn't affected by this bug only certain Android platforms that's why I asked those guys specifically to try it out. Let me know guys thanks!

marmotpie commented 9 years ago

Everything appears to be working as intended on 2.3.0. Each character loads correctly and I'm able to transfer and equip both Fang and Song of Ir Yut with no issues.

M3Rocket commented 9 years ago

Tried both Fand and Song. Works as intended for me.

dasilva333 commented 9 years ago

Alright thanks guys, hate to reopen a closed ticket but I just wanted to make sure there's no problem this time. Closing ticket as fixed

weborican commented 9 years ago

I'm a day late, but all is well with all the "Yuts" on Android and iOS at my end as well.