dasilva333 / TowerGhostForDestiny

Tower Ghost for Destiny - This app allows you to transfer items between profiles, with various filters.
112 stars 42 forks source link

3.9.0.10 Item Transfer Getting Stuck #620

Closed pattont closed 8 years ago

pattont commented 8 years ago

I am constantly having this issue trying to move a loadout on version 3.9.0.10. It gets like half-way and then constantly shows the blue refresh icons on the right and doesn't move anything else. I have to completely refresh the page and re-transfer that loadout and it will typically complete.

Just looking at the image, perhaps it's because it's trying to transfer a gunsmith pkg. image

rkingsla commented 8 years ago

From what I gather with other tools (Guardian GG, DestinyTracker) Bungie has done a great job on doing an update to their systems. Well, except for the fact that the API seems to be lagging well behind. IOW, tools like TGD and other interfaces using the Destiny Bungie API aren't working correctly. I suspect that this is the reason why things aren't transferring.

pattont commented 8 years ago

They are in-fact transferring, but it gets stuck refreshing. I then refresh the entire page and re-do the transfer and it's fine.

dasilva333 commented 8 years ago

Ill try a couple of examples with a variety of cases with guns and a ghost and see if I have any issues. I know the Bungie server's have been problematic lately and my transfer code depends on Bungie's server to reliably update when asked to refresh, I know that if the server is caching a certain item somewhere even though it's been moved it can cause real problems with the transfer code. Anyhow I'll check it out thanks for the heads up

pattont commented 8 years ago

Ever since I have manually swapped out any gunsmith orders from the transfer attempt there has been no issue. Perhaps you can exempt those from the transfer algorithm and it should be fine. On Fri, Jun 10, 2016 at 4:12 PM Richard Pinedo notifications@github.com wrote:

Ill try a couple of examples with a variety of cases with guns and a ghost and see if I have any issues. I know the Bungie server's have been problematic lately and my transfer code depends on Bungie's server to reliably update when asked to refresh, I know that if the server is caching a certain item somewhere even though it's been moved it can cause real problems with the transfer code. Anyhow I'll check it out thanks for the heads up

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/dasilva333/TowerGhostForDestiny/issues/620#issuecomment-225283885, or mute the thread https://github.com/notifications/unsubscribe/ACxNPaDh_UKUBaAs5awfYRyZxJzEdW9aks5qKcVJgaJpZM4Iy9FZ .

dasilva333 commented 8 years ago

Good catch guys, that was a tricky bug to find and I thank you all for helping me figure out this problem. I changed the transfer algorithm to only consider Equippable guns when unequipping a gun therefore preventing any Armsday Orders from trying to get equip and mess up the transfers. It should be ready as of 3.9.1.1 I'll let you guys know when it's available to try out. Thanks again

dasilva333 commented 8 years ago

@pattont can you confirm if the problem is still present as of 3.9.1.1? Let me know thanks!

pattont commented 8 years ago

Confirmed - resolved

You also resolved another issue I was about to post about and that was weirdness with transferring items between characters by clicking on them with Chrome for Mac. The character box wouldn't come up and I was forced to drag them. It didn't happen on Chrome for Windows, but it appears resolved. Will keep my eye out for any thing else.

Thanks for the great work!!

Travis On Wed, Jun 22, 2016 at 4:04 PM Richard Pinedo notifications@github.com wrote:

@pattont https://github.com/pattont can you confirm if the problem is still present as of 3.9.1.1? Let me know thanks!

— You are receiving this because you were mentioned.

Reply to this email directly, view it on GitHub https://github.com/dasilva333/TowerGhostForDestiny/issues/620#issuecomment-227860427, or mute the thread https://github.com/notifications/unsubscribe/ACxNPe2BPNM9n6gJJiC3X2hJWmBajz8Qks5qOZVcgaJpZM4Iy9FZ .