dasilva333 / TowerGhostForDestiny

Tower Ghost for Destiny - This app allows you to transfer items between profiles, with various filters.
113 stars 42 forks source link

Tower Ghost error: Please Sign in to Continue #635

Closed abqwizard closed 7 years ago

abqwizard commented 7 years ago

When trying to transfer items between characters, I keep getting ERROR: Please sign-in to continue. And I was already signed in. Tried restarting app, removed app and reinstalled. Updated to IOS 9.3.3 and same thing. This just started today, Wednesday 7/20/2016. Worked fine last night.

Tried on iPad, iPhone and Chrome same thing on all of them. The Firefox app seems to still work.

All are version 3.9.1.2

daize17 commented 7 years ago

I am having the same issue. Tried re-logging in multiple times, tried uninstalling the app and Chrome, and tried restarting, but continue to have the issue.

dasilva333 commented 7 years ago

Can confirm the issue as well, must be new API changes from Bungie I'll look into it thanks for the heads up

edmiller47 commented 7 years ago

Same thing was happening in DIM earlier, so most likely it's an API change related to today's Companion update.

MasterBry commented 7 years ago

Same problem here... All looks normal until you try to transfer anything, then says login, even when you are.

Ziggy0011 commented 7 years ago

Ditto - Chrome app looks normal but won't transfer. Uninstalled the extension and reloaded. No luck. Love the app. Actually I'm kinda addicted to it. :-)

dasilva333 commented 7 years ago

So it seems like DIM is working again despite no changes to their code, also TGD seems to work fine on Firefox but not on mobile/Chrome. I'll keep investigating to determine the issue, marking as help wanted if anyone wants to help

macnode commented 7 years ago

I also have this specific issue "ERROR: Please sign-in to continue."

DIM is working for me.

dasilva333 commented 7 years ago

After further research I have concluded the problem is with Bungie actively blocking requests from unknown Origins. It seems they changed the TransferItem API so it validates the Origin header if provided. If a value is provided it is checked against a whitelist of valid Origins. DIM must have been added to the whitelist: "Origin:chrome-extension://apghicjnekejhfancbkahkhdckhdagna" whereas Tower Ghost is not in the whitelist: "Origin:chrome-extension://nkplbklkoceoepkghofapmhjgidaialb". That would explain how it wasn't working between yesterday at 5 PM and it's working now without any code changes on their end.

Worthy of note is the Response header includes these two fields not provided to Tower Ghost when the request is made from DIM: Access-Control-Allow-Credentials:true Access-Control-Allow-Origin:chrome-extension://apghicjnekejhfancbkahkhdckhdagna

This is the resposne from Bungie when the request is made from Tower Ghost: Access-Control-Allow-Origin:https://www.bungie.net

Also worth noting Firefox does not send any Origin headers and manually removing the Origin header from Chrome seems to fix the issue however pushing these changes requires me to update the manifest and include new permissions for the app to modify the HTTP request in real time.

I messaged Bungie's Treton with a query as to what's going on hopefully I can be added to the white list to avoid any code changes on my side.

macnode commented 7 years ago

Thanks for looking into it! If you need any testing/data Im a cloud engineer and Bungie API user, and have been using TG daily for a long time. I also helped fill in the 335 data spreadsheet a while back as I hit 335 the first day.

dasilva333 commented 7 years ago

Update from Bungie: https://www.bungie.net/en/Clan/Post/39966/209412687/0/0

macnode commented 7 years ago

Cool. Cause found! By the way theres a maintenance today and usually the API is down during so not a good time to test TG...

jkewley commented 7 years ago

@dasilva333 TGD's chrome extention isn't mentioned in that thread. Did you message him directly? Don't make me use the destiny site gear manager again tonight - I won't forgive you.

dasilva333 commented 7 years ago

Yes I privately messaged them my Chrome Origin header it should be fixed soon enough, however it seems mobile will have to remain broken until I can push a workaround or until they can come up with a fix, I think i'll have a workaround sooner than their fix so expect 3.9.1.3 for mobile soon guys.

Thanks everyone

edmiller47 commented 7 years ago

TG Chrome is working again

MasterBry commented 7 years ago

Still same error happening, after re-boot, log off and login, continues to say Must Login

davefiley commented 7 years ago

Hi I'm on iPad using safari and suffering same issue signs in ok but as soon as I try to move anything app reports that I need to sign in.

tonyNOS commented 7 years ago

Hi everybody. Just to report 1) my firefox plugin its ok, 2)my desktop version not works

dasilva333 commented 7 years ago

As of 3.9.1.3 TGD works for iOS/Chrome/Firefox and Windows-Phone I'm still trying to figure out a way to get it working on Android again. Thanks guys

selloutpunk commented 7 years ago

Following for updates. Tower Ghost is my go to app.

iamlester55 commented 7 years ago

Thanks for the update @dasilva333 eagerly awaiting the android fix!

grimmjoww commented 7 years ago

Hopefully it gets fixed soon miss farming

CrazyPyro21 commented 7 years ago

I'm also anxiously waiting an android fix. I love TG. I've been lost without it lately. Thanks dasilva333.

CrazyPyro21 commented 7 years ago

Any updates dasilva333?

dasilva333 commented 7 years ago

I tried it on one of my mobile android devices yesterday and it seemed to have worked, I'll try my tablet tonight and hopefully I can reproduce the problem, otherwise I won't have a device to test the problem against. fingers crossed

CrazyPyro21 commented 7 years ago

I just checked on my Galaxy S7 Edge, and I'm still having it.

iamlester55 commented 7 years ago

I also tried on a rooted Note 3 and a Galaxy tab S2 and still get the same error :( I Uninstalled and reinstalled on both devices before trying.

Harshlanguage commented 7 years ago

I have been having the issue on Amazon Fire tablet. Works fine on Windows phone. Very frustrating. Have to carry multiple devices to game....Just tried to uninstall and reinstall on Fire tab with no success

krostyck commented 7 years ago

I am having the same issue. Tried re-logging in multiple times, tried uninstalling the app in Firefox, Windows 64x and Android, and tried restarting, but continue to have the issue.

CrazyPyro21 commented 7 years ago

Just wanted to check in again and let you know that I'm still unable to transfer items via tower ghost. I miss your app. Hope it's back up and running soon. Thanks.

Mythrayn82 commented 7 years ago

I LOVE your app! It makes me sad that it's not working. I've chosen to not play Destiny a few times simply because the app isn't working :'( I've logged out and back in, uninstalled and reinstalled. Updated to latest android OS. All to no avail. It sounds like my android devices are ones not fixed yet. Galaxy Note 5 and Galaxy S4.

I hope to hear good news soon! I REALLY don't want to go back to any of the other apps. Good luck in your search for answers!

paulR3 commented 7 years ago

Tower Ghost error: Please Sign in to Continue Is. Still happening 10:31pm EST 7/31/16

selloutpunk commented 7 years ago

Kindle... really..? You have bigger problems in life.

iamlester55 commented 7 years ago

@selloutpunk that is hilarious.

CrazyPyro21 commented 7 years ago

Well... That escalated quickly

edmiller47 commented 7 years ago

Folks - @dasilva333 stated earlier that he is working on a fix for Android, so if you've read this far, you already know that the Android version isn't working. No value added by posting more messages saying it doesn't work. The developer will let us all know when it's fixed as he always does.

jkewley commented 7 years ago

I don't want to step on the toes of @dasilva333 here, but if you're a dev who is experiencing these problems it'd probably be useful to configure your device to work through a PC-based proxy such as Fiddler and capture the requests and responses. That data should be useful as he tries to get a better understanding of where things are falling apart.

There is also an updated work around on the original thread https://www.bungie.net/en/Clan/Post/39966/209412687/0/0 which apparently fixed DIM. Might be worth a try.

rkingsla commented 7 years ago

@ryanhubbard69 I just want to point one thing out: This isn't Microsoft, Apple, Oracle or any of the other big names that you're paying big bucks for an application and a support team. I work for a software house and we have dedicated support, engineers (who do this full time), and such. Our customers have a right to demand things from us. When you're not paying big dollars (or choose your currency), you don't have a right to bitch (frankly, you have a right to bitch regardless and I'll defend your right to do so). However, you nor I have any idea what is going on in @dasilva333 's life that might have put him off-track. Family issues? Dunno. Demands at his 'real job'? (No one believes that he's making enough off of this to make it a full-time job, do they?) Dunno.

Temper your expectations. If you choose to donate, great. Otherwise, @dasilva333 is giving this to you FOR FREE - and hence the reason that you should likely re-think 'demands' for a fix. In summary, no one was guaranteed anything.

dasilva333 commented 7 years ago

Thanks everyone for staying on top of this, so I can finally provide an update today I've got good news and bad news.

For the good news I have 2 Android devices, on the first one I'm able to login and make transfer requests without the Sign In bug, I wasn't able to test the same code on my other Android (a tablet running 4.0.4) because there was a problem with inAppBrowser that was fixed 2 weeks ago that prevented the sign in pop up from showing. So I built the code using the latest version provided with the fix, logged in, and to my surprise this device also doesn't send the Origin header.

So for the bad news I am unable to reproduce the bug (though I know it exists because my buddy is able to reproduce it with his Android) with my two devices, I'm going to ask my other buddy @weborican if he can provide me with a test Android device I can reproduce the problem with.

As an interim solution @jkewley is not far off, if you can reproduce the bug on your device and you have knowledge with Fiddler or Charles to read the SSL-bound www.bungie.net requests for the TransferItem API all I need to know is what your device is using for an Origin header. I'm pretty sure it's dynamic based on where it's installed but I dont mind submitting to Bungie all the variations (if possible) for the time being just to get you guys up and running again.

Thanks again

roland46 commented 7 years ago

Hi,

I have the problem on a windows 10 pc. On a Microsoft Surface windows 10.

My android phone works, no tablet to test on.

My windows phone works, I think this is on windows phone 8.1.

Not sure if this helps, but any input to help you get this solved gladly given.

I have had a look on the bungie site, but that does not appear to be much help, anything needed to help you out let me know, can try to run some trace tools, just need to know what you need.

Cheers, Roland.

dasilva333 commented 7 years ago

Alright these instructions is for anyone receiving the 'Please Sign on to Continue' error whilst using Tower Ghost.

The gist of it is you'll set up a sniffing tool, configure it for Bungie, install the certificate on your device, and then use TGD.

Requirements

Good luck everyone!

LordofthStrings commented 7 years ago

So is this just it for tower ghost or are you working on a more convenient fix ? Because i am not familiar with pretty much anything involved in this fix lol. Also if anybody could post the phones/ tablets that ARE working with TG that would be appreciated as I am considering getting a new phone anyway.

dasilva333 commented 7 years ago

Problem can't be reproduced by the two testers who were able to previously confirm the problem was there. To everyone following this issue please retest your app and let me know if you're still having issues. If no one comes forward with the issue I'll assume Bungie ninja patched it within the last few hours and close this ticket later.

Thanks everyone

CrazyPyro21 commented 7 years ago

Just checked. Now working for me!

LordofthStrings commented 7 years ago

Working for me as well yay!!!

hendersj commented 7 years ago

Confirmed here as well on a Galaxy Tab S 10.5 and a Galaxy S6.

Thanks for the hard work resolving this - I was really missing farm mode last night - glad to have it back today. :)

edmiller47 commented 7 years ago

Working on my Blackberry now (yes, I have a Blackberry)...

Mythrayn82 commented 7 years ago

It seems to be working again for me too! Yay!

iamlester55 commented 7 years ago

Can confirm that the fix works in a rooted note 3 running cm12

tonyNOS commented 7 years ago

Windows64 here, thanks god it works.

Of course thanks to dasilva too.

grimmjoww commented 7 years ago

Did you already changed the header . App is working now