dasilva333 / TowerGhostForDestiny

Tower Ghost for Destiny - This app allows you to transfer items between profiles, with various filters.
113 stars 42 forks source link

Emblem image is missing. #652

Closed karlwilbur closed 7 years ago

karlwilbur commented 7 years ago

screenshot from 2016-08-25 19 37 59 When I load Tower Ghost in Google Chrome, all characters using the "Hear the Call" emblem (Year 2 Moments of Triumph reward) are missing their emblem image. Switching to a different, older emblem and updating Tower Ghost will then display the correct emblem for that character. Switching back to Hear the Call will just leave the older emblem displayed after refresh.

Not really a functional issue but it does make it slightly more difficult to transfer items to characters because their mouse target is small (only the letter "H", "W", or "T").

karlwilbur commented 7 years ago

This may be related to #632.

dasilva333 commented 7 years ago

Consider the problem fixed as of 3.9.2, let me know if it's still an issue thanks

karlwilbur commented 7 years ago

This seems to be partly fixed in 3.9.1.3.

screenshot from 2016-08-26 16 32 10

dasilva333 commented 7 years ago

It should be fully fixed now, let me know if there's still any issues. Thanks!

rkingsla commented 7 years ago

FWIW, I still see the images for the Moments of Triumph missing in the loadout or multi-item transfer screen. Merely a nit, I know.

From: Richard Pinedo [mailto:notifications@github.com] Sent: Tuesday, August 30, 2016 2:34 PM To: dasilva333/TowerGhostForDestiny TowerGhostForDestiny@noreply.github.com Subject: Re: [dasilva333/TowerGhostForDestiny] Emblem image is missing. (#652)

It should be fully fixed now, let me know if there's still any issues. Thanks!

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub https://github.com/dasilva333/TowerGhostForDestiny/issues/652#issuecomment-243553312 , or mute the thread https://github.com/notifications/unsubscribe-auth/AB8VO4izg6WW7wopkRai_cKYxJTZ8NfXks5qlIWcgaJpZM4Jtmxa . https://github.com/notifications/beacon/AB8VOxWBUqrj2swdn0DT0wxOEVkY4Nlyks5qlIWcgaJpZM4Jtmxa.gif

karlwilbur commented 7 years ago

Yes, there are are still some places missing the "Hear the Call" emblem (see attached screenshots). Again, this is not an issue with functionality. It still works for transferring items but the mouse target is smaller that what was intended because the image is missing.

Using Hear the Call: screenshot from 2016-08-31 14 24 53

Not using Hear the Call: screenshot from 2016-08-31 14 29 00

karlwilbur commented 7 years ago

Since the original issue as reported is still not fixed, should I make a new issue for this or would you rather re-open this one?

rkingsla commented 7 years ago

I'll save everyone the trouble. The reply to Richard's email that I sent and the one from @karlwilbur are both fixed in a coming update. From the latest commits:

2016-08-31_15-10-45 2016-08-31_15-10-09

karlwilbur commented 7 years ago

Excellent!! Thanks!