search

dask-contrib / dask-sql

Distributed SQL Engine in Python using Dask
https://dask-sql.readthedocs.io/
MIT License
376 stars 71 forks source link

Drop latest datafusion testing from nightly tests #1296

Closed charlesbluca closed 5 months ago

charlesbluca commented 5 months ago

I've found that in practice, the nightly tests against latest DataFusion don't really provide much actionable information, and increases the toil around diagnosing failures coming from latest Dask, which are relatively common.

I've still left the logic for using latest DataFusion in PRs, so we still have a mechanism to it if needed.

cc @ayushdg

codecov-commenter commented 5 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Comparison is base (f53c3e0) 82.73% compared to head (3f6a1ad) 85.52%.

:exclamation: Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #1296 +/- ## ========================================== + Coverage 82.73% 85.52% +2.79% ========================================== Files 75 77 +2 Lines 4158 4256 +98 Branches 772 794 +22 ========================================== + Hits 3440 3640 +200 + Misses 549 447 -102 Partials 169 169 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

ayushdg commented 5 months ago

Agreed, thanks for the cleanup @charlesbluca.