search

dask-contrib / dask-sql

Distributed SQL Engine in Python using Dask
https://dask-sql.readthedocs.io/
MIT License
386 stars 71 forks source link

Test import with dask-expr on CI #1309

Closed hendrikmakait closed 5 months ago

hendrikmakait commented 7 months ago

Addresses #1308.

This PR is a first step toward ensuring compatibility with dask-expr. After getting the import to work at all, I recommend running the entire test suite with dataframe.query-planning=True on CI.

codecov-commenter commented 7 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 85.09%. Comparing base (93bb1e5) to head (082fd48).

:exclamation: Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #1309 +/- ## ========================================== - Coverage 85.54% 85.09% -0.46% ========================================== Files 77 77 Lines 4261 4259 -2 Branches 795 753 -42 ========================================== - Hits 3645 3624 -21 - Misses 447 466 +19 Partials 169 169 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

charlesbluca commented 5 months ago

Superseded by #1319