dask-contrib / dask-sql

Distributed SQL Engine in Python using Dask
https://dask-sql.readthedocs.io/
MIT License
376 stars 71 forks source link

Install `x86_64-apple-darwin` target before building bindings on `macos-latest` #1329

Closed charlesbluca closed 2 months ago

charlesbluca commented 2 months ago

Looks like we're starting to see failures in our macOS test builds:

https://github.com/dask-contrib/dask-sql/actions/runs/8852325552/job/24312113450?pr=1328

Taking the suggestion from the error logs seems to resolve things:

  = note: the `x86_64-apple-darwin` target may not be installed
  = help: consider downloading the target with `rustup target add x86_64-apple-darwin`
codecov-commenter commented 2 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 76.74%. Comparing base (b473fd6) to head (7db333d).

:exclamation: Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #1329 +/- ## ========================================== - Coverage 85.32% 76.74% -8.58% ========================================== Files 77 77 Lines 4231 4231 Branches 791 791 ========================================== - Hits 3610 3247 -363 - Misses 453 838 +385 + Partials 168 146 -22 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.