search

dask / community

For general discussion and community planning. Discussion issues welcome.
20 stars 3 forks source link

Tracking code coverage #146

Open jakirkham opened 3 years ago

jakirkham commented 3 years ago

Some projects track code coverage (in terms of lines tested). This can be helpful when identifying what lines are still not covered generally as well as with specific PRs adding new features. Wondering what others think about tracking coverage in Dask, Distributed, and possibly other libraries 🙂

jrbourbeau commented 3 years ago

Thanks for raising this issue @jakirkham. For reference, Dask tracks code coverage today (see https://codecov.io/gh/dask/dask/branch/main). I'd be in favor of adding something similar to Distributed (in fact I might try that out this afternoon).

jakirkham commented 3 years ago

TIL 😄

Thanks James! Please let us know if you need another hand 🙂

hristog commented 3 years ago

Would it make sense to add the same to dask-ml as well? If yes, I'll be happy to raise a PR. Edit: Just noticed that the Codecov run for dask-ml was most recently executed about a year ago.

hristog commented 3 years ago

Raised https://github.com/dask/dask-ml/pull/816 to update the dask-ml badges, and noticed that, according to Codecov, a master branch exists, but a main branch doesn't (https://github.com/dask/dask-ml/issues/817). That's might be one of the reasons why Codecov hasn't performed recent dask-ml checks.

It seems to me that Codecov stopped running on dask-ml when it was removed from posix.yaml as part of https://github.com/dask/dask-ml/commit/fddc19d563577b206e032cdcc4d06dec3bf76c23 (https://github.com/dask/dask-ml/pull/634).

As a side note, it's not immediately obvious to me what facilitates the generation of the coverage report that's part of the Azure Pipelines. Not sure if its posix.yaml or windows.yaml and/or something else.

jrbourbeau commented 3 years ago

Thanks @hristog for looking into things for dask-ml. Let's move the dask-ml specific discussion over to the issues you've opened up there.

@jakirkham in light of dask already tracking coverage and https://github.com/dask/distributed/pull/4670, is it safe to close this issue? Or is there something else to do here? Perhaps folks should open up an issue/PR on the specific sub-project they're interested in