search

dask / community

For general discussion and community planning. Discussion issues welcome.
20 stars 3 forks source link

Workflows Awaiting Approval #158

Closed jsignell closed 2 years ago

jsignell commented 3 years ago

This is mostly a PSA. Apparently, new contributors have to have their workflow runs approved by maintainers now.

I just ran into this on https://github.com/dask/dask/pull/7706

image

The tests did not run until I hit "Approve and Run".

fjetter commented 3 years ago

That's a security feature of github actions to avoid execution of malicious code and/or abusing of compute resources, e.g. by bots. I am not aware of any way to disable this.

For reference, the Learn more points to https://docs.github.com/en/actions/managing-workflow-runs/approving-workflow-runs-from-public-forks

quasiben commented 3 years ago

I've also run into this a few times. As @fjetter said, it seems like something to prevent crypot-miners on CI systems

jsignell commented 3 years ago

Oh yeah, I was just raising this so people are aware that we need to be extra diligent about looking at PRs since new contributors don't get CI runs until we explicitly allow them.

GenevieveBuckley commented 2 years ago

A newer discussion on the same topic is here: https://github.com/dask/community/issues/191

jsignell commented 2 years ago

I'll go ahead and close this one, since @jacobtomlinson's has more of a path forward :)

sufsid commented 2 years ago

1 workflow awaiting approval First-time contributors need a maintainer to approve running workflows when can I expect this to be approved?