search

dask / community

For general discussion and community planning. Discussion issues welcome.
20 stars 3 forks source link

Stale issue / PR sprint #188

Closed jrbourbeau closed 2 years ago

jrbourbeau commented 3 years ago

As discussed in the maintainers meeting today, it's a good time for another stale issue / PR sprint. I'll propose next Thursday, October 14, from 9 AM - 1 PM CT in the Dask whereby channel. This should hopefully provide a large enough windows for folks (both US and Europe based) to come and go as they please / their schedule allows.

cc @jcrist @ncclementi @jsignell @quasiben @jacobtomlinson @douglasdavis who expressed an interest in the sprint. Does this time window work for you?

GenevieveBuckley commented 3 years ago

BTW, I'd also be happy to chip in towards this effort.

My timezone is UTC+11, so that works for a UK/Euro morning, or US folks who might want to have an evening round at it. I get it if that's not convenient for anyone else.

Also, if there's anything asynchronous I can do to help, let me know. Maybe sorting through old issues/PRs and tagging them, so other people can spend more effort on reviewing? I don't currently have permissions to do that now, but I'm sure we could get that worked out if there was a specific task in mind.

jsignell commented 3 years ago

Oooh let's add @GenevieveBuckley to the triage team

jrbourbeau commented 3 years ago

+1! @GenevieveBuckley I just added you to the @dask/triage team. You should be able to re-open, close, and label issues/PRs in dask/dask and dask/distributed now

GenevieveBuckley commented 3 years ago

Thanks! Ok, if I go through old issues/PRs, what do you want me to tag? I could go through and label everything older than a certain date as "stale", but that may or may not be the most helpful thing to do...

fjetter commented 3 years ago

FYI there is an open PR to enable a GH actions to close stale PRs https://github.com/dask/distributed/pull/5402 I think we should open that discussion again, see also https://github.com/dask/community/issues/60

jsignell commented 3 years ago

if I go through old issues/PRs, what do you want me to tag?

I think needs-info, good-*-issue and the regular tags would be useful. Sometimes when you stare at the issue tracker for long enough you can also spot duplicates.

GenevieveBuckley commented 3 years ago

Ok, I've been working my way backwards from the oldest open issues. I'm up to the start of August 2019.

So far I've:

There several places that might be good for easy wins in our sprint:

  1. https://github.com/dask/dask/issues/6566 (corresponding issue https://github.com/dask/dask/issues/731)
  2. https://github.com/dask/dask/pull/3630 (corresponding issue https://github.com/dask/dask/issues/2959)
  3. https://github.com/dask/dask/pull/8206 (corresponding issue https://github.com/dask/dask/issues/8201)
  4. https://github.com/dask/dask/pull/5631 (corresponding issue https://github.com/dask/dask/issues/4275)
  5. https://github.com/dask/dask/issues/2568 (this needs a maintainer to do it, someone with permissions to the dask read the docs instance)
  6. (Documentation update) https://github.com/dask/dask/issues/4253
  7. (Documentation update) https://github.com/dask/dask/issues/2807#issuecomment-435448751
  8. https://github.com/dask/dask/issues/2812
GenevieveBuckley commented 3 years ago

Closed another 13 issues today.

Here are some more places to look for potential easy wins:

  1. https://github.com/dask/dask/pull/8221 (corresponding issue https://github.com/dask/dask/issues/5865)
  2. https://github.com/dask/dask/pull/6456 (corresponding issue https://github.com/dask/dask/issues/5695)
  3. https://github.com/dask/dask/pull/6344 (corresponding issue https://github.com/dask/dask/issues/6315)
  4. https://github.com/dask/dask/pull/6276 (corresponding issue https://github.com/dask/dask/issues/6275)
  5. https://github.com/dask/dask/pull/6627 (corresponding issue https://github.com/dask/dask/issues/6161)

I'm up to November 2020 in dask's open issues, working towards newer issues (haven't looked at open PRs or dask/distributed just yet).

GenevieveBuckley commented 3 years ago

Closed another 7 issues today (that's 35 in total :tada:).

I've finished looking through all the open dask issues. I have not looked at the distributed issues, or the dask or distributed PR backlogs.

Again, I found a bunch more places the maintainer team can look at for easy wins in this stale issue/PR sprint. They are:

  1. https://github.com/dask/dask/issues/6768
  2. https://github.com/dask/dask/pull/8259 (corresponding issue https://github.com/dask/dask/issues/6808)
  3. https://github.com/dask/dask/issues/7167
  4. https://github.com/dask/dask/pull/7688 (corresponding issue https://github.com/dask/dask/issues/7647)
  5. https://github.com/dask/dask/pull/8138 (it doesn't close the related issue, this is more of an in the meantime, raise and exception situation)

I also have a list of issues that maybe could be closed, but need some kind of discussion or interaction before that happens. Happy to share that too, but I think it makes sense to look at that list of possible easy wins first.

GenevieveBuckley commented 3 years ago

Update: closed 24 issues in the dask/distributed repository today (up to October 2017, working forwards through time).

I don't have a list of potential easy wins for you this time, most distributed stuff seems fairly complex. I did label a few "good second issue", but I'm just guessing. I have not been thoroughly labeling everything like I did in the dask repo (but I have asked Jacob if he can make a "discussion" label).

I'm running out of steam a little bit, so I might take a break from looking through old issues, depending on how I feel.

GenevieveBuckley commented 3 years ago

Update: closed another 25 issues in the dask/distributed repository today (up to 10th November 2018, working forwards through time). I find the distributed issues harder to skim than issues in dask/dask, so it's much slower going and I might easily be missing stuff.

Potential easy wins for the sprint in dask/distributed:

GenevieveBuckley commented 3 years ago

Update: closed 19 issues today (up to 25th June 2019, working forwards through time in the dask/distributed open issues).

Potential easy wins:

GenevieveBuckley commented 2 years ago

Update: closed 12 issues over the last two days.

Found another possible easy-ish win:

I'm up to Jan/Feb 2020 in the dask/distributed open issues, so everything newer than that, I haven't looked at. I'm going to stop here, I think we're now at the point of diminishing returns. It makes more sense to focus maintenance efforts on the PR backlog now.

I might be able to pair with someone to go through PRs. The napari project is doing something similar next week.

GenevieveBuckley commented 2 years ago

Here's another one for the list of potential easy wins: