dask / community

For general discussion and community planning. Discussion issues welcome.
20 stars 3 forks source link

Add readthedocs OAuth app to dask-contrib #224

Closed charlesbluca closed 2 years ago

charlesbluca commented 2 years ago

While doing some documentation work on Dask-SQL, I noticed that we do not have readthedocs build checks showing up on pull requests, as is the case in Dask and Distributed.

Checking out the RTD settings for the project, I see that PR builds are enabled and running, but the checks still aren't showing up on pull requests. According to RTD's troubleshooting page for PR builds, access must be granted to RTD's OAuth app on a personal / organization account for the build statuses to be reported.

Would it be possible to authorize this OAuth app on the dask-contrib organization if this hasn't been done already?

cc @jrbourbeau

jrbourbeau commented 2 years ago

Authorizing readthedocs sounds great. I didn't see an authorization request in the "Third-party access" setting in the dask-contrib org. If you know how to make that request, I'm happy to approve it. Otherwise, it might be worth us syncing offline to figure out how to request / grant access

charlesbluca commented 2 years ago

I just followed the steps outlined on this page to request access - I believe that should've sent an email requesting access to all owners of dask-contrib

quasiben commented 2 years ago

If it's ok with you @jrbourbeau I'm happy to push the button

jrbourbeau commented 2 years ago

Thanks @charlesbluca -- just pressed the green button (@quasiben definitely feel free to press it in the future)

charlesbluca commented 2 years ago

Thanks for the help @jrbourbeau @quasiben 😄