Closed jrbourbeau closed 1 year ago
It would be useful to get dask/distributed#6991 in, as recent juptyer_client releases require tornado>=6.2
while distributed is currently on <6.2
.
Thanks @wence-. I threw that in the "best effort" category but not "blocker" -- that's my current understanding at least. Just as a heads up the folks who would normally push on tornado
version compatibility (@fjetter, @crusaderky, etc.) are all at an offsite IRL meeting this week, so I suspect they won't have many cycles to devote towards development work this week. Do you have bandwidth for pushing on tornado=6.2
compatibility?
Thanks @wence-. I threw that in the "best effort" category but not "blocker" -- that's my current understanding at least. Just as a heads up the folks who would normally push on
tornado
version compatibility (@fjetter, @crusaderky, etc.) are all at an offsite IRL meeting this week, so I suspect they won't have many cycles to devote towards development work this week. Do you have bandwidth for pushing ontornado=6.2
compatibility?
I can try. My understanding of that PR is that everything "should work"; there are no code changes only updates to the version pins. I think it needs a merge from trunk to get into a passing state but I don't have privileges: I can mimic the changes and create a new PR if that is useful.
In addition to the version pins, we're currently using some methods that are deprecated in tornado=6.2
. Removing those deprecated method calls is the remaining thing we still need to do
In addition to the version pins, we're currently using some methods that are deprecated in
tornado=6.2
. Removing those deprecated method calls is the remaining thing we still need to do
OK, let me have a go.
Thanks for being willing to take a crack at this Lawrence
On Wed, Oct 12, 2022 at 5:11 PM Lawrence Mitchell @.***> wrote:
In addition to the version pins, we're currently using some methods that are deprecated in tornado=6.2. Removing those deprecated method calls is the remaining thing we still need to do
OK, let me have a go.
— Reply to this email directly, view it on GitHub https://github.com/dask/community/issues/281#issuecomment-1276341533, or unsubscribe https://github.com/notifications/unsubscribe-auth/AACKZTHZIZWBNXMUKOPUJULWC3IJPANCNFSM6AAAAAARCYY35E . You are receiving this because you are subscribed to this thread.Message ID: @.***>
In addition to the version pins, we're currently using some methods that are deprecated in
tornado=6.2
. Removing those deprecated method calls is the remaining thing we still need to doOK, let me have a go.
dask/distributed#7134 (brings in the changes to the environment pins from dask/distributed#6991)
It might also be nice to get in
Going to start pushing out the release in a few minutes
2022.10.0 is on PyPI
conda-forge packages and docker images are out. Thanks all!
Best effort
Try to close before the release but will not block the release
Blocker
Issues that would cause us to block and postpone the release if not fixed
Comments
cc @fjetter @ian-r-rose @jakirkham @quasiben