search

dask / dask-blog

Dask development blog
https://blog.dask.org/
30 stars 35 forks source link

Fix broken mybinder links for dask-examples notebooks #112

Closed GenevieveBuckley closed 3 years ago

GenevieveBuckley commented 3 years ago

All the binder badge links are broken, this PR restores that functionality.

They broke for two reasons:

  1. The dask-examples "main" branch was recently renamed (previously named "master"), and
  2. A backwards incompatible change happened in the way binder generates/parses links (see here for more details)

Neither of these should be a problem going forward. However, we will need to be careful with the way people generate binder badges for dask-examples - if you use https://mybinder.org/ it will give you a link that only works for newer versions. We can either:

Cross reference: https://github.com/dask/dask-examples/issues/196

GenevieveBuckley commented 3 years ago

(I'm not going to wait for discussion before merging, it's fixing a problem so we probably don't want to leave the links broken for longer than they need to be. I've checked the updated links individually & they all seem to be working now.)