Open jrbourbeau opened 3 years ago
For reference, since our build
workflow will push to docker hub on push
events with a new tag
I ended up manually deleting the 2021.8.1 tag (which was generated from the autotag
workflow) and pushing an empty commit to main
with a new 2021.8.1 tag (https://github.com/dask/dask-docker/commit/3362618f21512dfb66a42877ccd846375e611a66). This resulted in docker images for the new release being published
Thanks for writing this up @jrbourbeau. I'll take a look at these.
Curious how many of these are still issues
IIUC all of the unchecked boxes in the original post are still valid
I've fixed up a few things and checked a few boxes in the post above that I can confirm as resolved.
The last outstanding one is the auto merge, I'm not sure if this is fixed by the other changes I've made so let's wait until the next release and see what happens. cc @jrbourbeau @jsignell.
ping @jrbourbeau @jsignell how did things go with the latest release?
I see some extra changes were pushed to the PR so I'm guessing the find and replace still isn't working quite right, and the automerge didn't work. Is there anything else?
Yeah, that's correct. I also noticed that the autotag workflow did assign a 2022.4.0
tag, but assigning that tag didn't result in us pushing Docker images to Docker Hub or ghcr.io. As of now the latest images available are for 2022.3.0
. I should also note that deleted the 2022.4.0
tag which was automatically added and manually re-added the tag myself to see if that would help, but it did not
A couple unexpected things happened with the latest automatic release procedure:
automerge
label was applied to the PR, it wasn't automatically merged after all CI checks passed. xref https://github.com/dask/dask-docker/pull/178build
CI jobs ran on https://github.com/dask/dask-docker/pull/178. I suspect this is because we're triggering on bothpull_request
andpush
events https://github.com/dask/dask-docker/blob/e82ac06b362319833954ae64687061606f22b924/.github/workflows/build.yml#L3release: XXXX.XX.X
field inbuild/docker-compose.yml
but not.github/workflows/build.yml
(xref https://github.com/dask/dask-docker/pull/179). EDIT: fixed by https://github.com/dask/dask-docker/pull/181