Closed mrocklin closed 7 years ago
Does anyone know why this PR might cause this failure?
_____________________________ test_provision_salt ______________________________
cluster = {'region': 'foo', 'instances': [{'port': 2222, 'uid': 1, 'keypair': '~/.vagrant.d/insecure_private_key', 'username': '...}, {'port': 2223, 'uid': 1, 'keypair': '~/.vagrant.d/insecure_private_key', 'username': 'root', 'ip': 'ci_compute_1'}]}
@remotetest
def test_provision_salt(cluster):
result = invoke("provision")
if result.exit_code != 0:
print(result.output_bytes)
> assert result.exit_code == 0
E assert 1 == 0
E + where 1 = <Result SystemExit(1,)>.exit_code
I dont think thats the reason
If so then is it safe to merge this PR? (I am prepping for a talk for tonight)
Actually it is:
Failed to install packages: dask-glm. Error: Collecting dask-glm Could not find a version that satisfies the requirement dask-glm (from versions: )
pip cannot find the package?
Yeah, i dont see dask-glm
it on pypi
Ah, ok. I guess I need to learn to read logs on dask-ec2 test failures.
Thank you @danielfrg
Merging soon if there are no objections
👍
Coverage remained the same at 74.61% when pulling e0d1834fce2fec3d8e0c3cb2eb1037d03c012361 on mrocklin:update-notebooks into 59ef0d665109b3c297484954e1dcd99f68151ea8 on dask:master.