search

dask / dask-gateway

A multi-tenant server for securely deploying and managing Dask clusters.
https://gateway.dask.org/
BSD 3-Clause "New" or "Revised" License
135 stars 87 forks source link

Use alembic to version database #31

Open jcrist opened 5 years ago

jcrist commented 5 years ago

To handle potential database migrations, we should be using alembic to manage database versions.

consideRatio commented 2 years ago

Is there a database involved still in the dask-gateway architecture? I see none in the k8s deployment that relies on DaskCluster resources, but perhaps the other deployments of dask-gateway works with a database somehow?

martindurant commented 2 years ago

In the case of yarn, the "database" is they key-value store in skein. I don't know about the job schedulers.

jcrist commented 2 years ago

I think you're confusing that with something else Martin. All backends other than the k8s backend store state in a configurable database (similar to jupyterhub). By default this is a local sqlite file. These backends all subclass from DBBackendBase, which handles all the DB logic, see https://github.com/dask/dask-gateway/blob/main/dask-gateway-server/dask_gateway_server/backends/db_base.py.

I still see migrations as something that may be nice to have later, but don't see them as high priority for now.

martindurant commented 2 years ago

Sorry, my mistake