search

dask / dask-gateway

A multi-tenant server for securely deploying and managing Dask clusters.
https://gateway.dask.org/
BSD 3-Clause "New" or "Revised" License
136 stars 88 forks source link

Don't always set imagePullPolicy to IfNotPresent #769

Closed consideRatio closed 10 months ago

consideRatio commented 10 months ago

I think this should be configured to not default to explicitly setting IfNotPresent but instead omitting it by default. The default behavior when omitted is as Always if the image tag is latest, and otherwise IfNotPresent. This fix would be similar to https://github.com/jupyterhub/kubespawner/pull/807 and shouldn't be a change that is disruptive for users, but rather a possible bugfix.

    image_pull_policy = Unicode(
        "IfNotPresent",
        help="The image pull policy of the docker image specified in ``image``",
        config=True,
    )
consideRatio commented 10 months ago

Closed by #770