CI is currently failing

dask / dask-jobqueue

Deploy Dask on job schedulers like PBS, SLURM, and SGE

https://jobqueue.dask.org

BSD 3-Clause "New" or "Revised" License

235 stars 142 forks source link

CI is currently failing #613

Closed guillaumeeb closed 3 months ago

guillaumeeb commented 1 year ago

Two things to look at:

none build which mainly do code formatting checks (see https://github.com/dask/dask-jobqueue/pull/610#issuecomment-1665311514).
Docker image builds, might be due to Python version problem. (https://github.com/dask/dask-jobqueue/pull/606#issuecomment-1579045899)

jrueb commented 1 year ago

One thing I noticed is that this looks really outdated https://github.com/dask/dask-jobqueue/blob/4bbd0a08342926ee8728ccd9a4559be3aa3ec628/.pre-commit-config.yaml#L7 flake8 moved to github years ago, see https://flake8.pycqa.org/en/latest/release-notes/4.0.0.html "Migrate from GitLab to GitHub"

kaelancotter commented 8 months ago

Are you looking for help with this?

guillaumeeb commented 8 months ago

Definitely!

kaelancotter commented 8 months ago

Created PR 636 to resolve CI failures.
Unfortunately CI fails in the PR since the updated images aren't pushed from the build step if its a PR - so CI action is still using the old docker images. LMK if there's another direction I should take this to deal with the docker image catch-22

Specific to SGE tests - adding the --full-trace flag got rid of the seg fault, but I don't have a good root cause analysis.

This PR also doesn't address CI for documentation.

jacobtomlinson commented 3 months ago

CI is in a much better place. #653 is still outstanding but I think we can close this issue in favour of that one.