dask / dask-kubernetes

Native Kubernetes integration for Dask
https://kubernetes.dask.org
BSD 3-Clause "New" or "Revised" License
312 stars 148 forks source link

Incorrect example code snippet in the Autoscalers section of the docs index page #904

Closed marcelovilla closed 2 months ago

marcelovilla commented 2 months ago

Describe the issue:

In the Autoscalers section of the docs index page, there's an incorrect example code snippet on how to create a KubeCluster and scale it. Here is screenshot:

image

Initially, I thought it was a duplicate snippet but @jacobtomlinson has pointed out it's actually an incorrect example and it should depict how to adapt a cluster to use the autoscaler.

jacobtomlinson commented 2 months ago

Thanks! The example isn't a duplicate, but it is broken. See my comment on your PR https://github.com/dask/dask-kubernetes/pull/905#pullrequestreview-2276582837

marcelovilla commented 2 months ago

@jacobtomlinson ah, I see! That makes sense. Let me update the issue title and description to better convey this.