dask / dask-labextension

JupyterLab extension for Dask
BSD 3-Clause "New" or "Revised" License
311 stars 62 forks source link

Logos no longer working well #261

Closed mrocklin closed 1 year ago

mrocklin commented 1 year ago
mamba create -n test dask jupyterlab dask-labextension
jupyter lab
Screen Shot 2023-05-24 at 7 46 55 AM

Notice both:

  1. The Dask logo on the side bar has a grey box behind it
  2. The Dask logos in the Task Stream and Progress frames don't exist

cc @ian-r-rose in case you have time to look into this. cc @jacobtomlinson and @dchudz (and team) in case he doesn't

(test) $ jupyter --version
Selected Jupyter core packages...
IPython          : 8.13.2
ipykernel        : 6.23.1
ipywidgets       : not installed
jupyter_client   : 8.2.0
jupyter_core     : 5.3.0
jupyter_server   : 2.5.0
jupyterlab       : 4.0.0
nbclient         : 0.8.0
nbconvert        : 7.4.0
nbformat         : 5.8.0
notebook         : not installed
qtconsole        : not installed
traitlets        : 5.9.0
mrocklin commented 1 year ago

Things work fine if I install jupyterlab=3

mrocklin commented 1 year ago

Or @fjetter in case someone on your team has JS experience

ian-r-rose commented 1 year ago

Yeah, probably a Jlab 4 issue. I’ll try to look at it this weekend.

On Wed, May 24, 2023 at 5:55 AM Matthew Rocklin @.***> wrote:

Or @fjetter https://github.com/fjetter in case someone on your team has JS experience

— Reply to this email directly, view it on GitHub https://github.com/dask/dask-labextension/issues/261#issuecomment-1561094458, or unsubscribe https://github.com/notifications/unsubscribe-auth/ABLWQN7TWJ25SXPEGU3UWDDXHYANHANCNFSM6AAAAAAYNKSQV4 . You are receiving this because you were mentioned.Message ID: @.***>

dchudz commented 1 year ago

@ian-r-rose if you have a chance to even just point us the right direction that'd be appreciated! Coiled folks don't have a ton of experience working on this, but we're happy to learn.