Open stsievert opened 5 years ago
thanks. I'm pushing up a commit now adding add_indicator to the signature and raising if it's set.
We can implement add_indicator
later if there's interest.
link to docs: https://scikit-learn.org/dev/modules/generated/sklearn.impute.SimpleImputer.html
Repurposed this issue to implement add_indicator.
What verbose indicates here? Can you please help me in understanding it?
It should have the same meaning as in scikit-learn.
On Thu, Oct 3, 2019 at 7:19 AM Nikita Malhotra notifications@github.com wrote:
What verbose indicates here? Can you please help me in understanding it?
— You are receiving this because you commented. Reply to this email directly, view it on GitHub https://github.com/dask/dask-ml/issues/494?email_source=notifications&email_token=AAKAOIWOHDJP2VY7MK5QMK3QMXPN7A5CNFSM4HFRLDFKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEAIAI4I#issuecomment-537920625, or mute the thread https://github.com/notifications/unsubscribe-auth/AAKAOIVUN522FAGW7DLIQO3QMXPN7ANCNFSM4HFRLDFA .
Obviously it is the class of Scikit and your answer is not an answer. I wanted to know the purpose of verbose and you did not tell me.
How would you want add_indicator
implemented? The same way as in sklearn, including MissingIndicator()
and all?
I think ideally it would be the same as scikit-learn, but I don't quite understand what that would be just from reading the documentation.
On Wed, Oct 28, 2020 at 1:45 PM Tobias Schmidt notifications@github.com wrote:
How would you want add_indicator implemented? The same way as in sklearn, including MissingIndicator() and all?
— You are receiving this because you commented. Reply to this email directly, view it on GitHub https://github.com/dask/dask-ml/issues/494#issuecomment-718135405, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAKAOIRKUQUMVF6PM77XSELSNBRGNANCNFSM4HFRLDFA .
Looks like a
indicator_
attribute was added tosklearn.impute.SimpleImputer
in https://github.com/scikit-learn/scikit-learn/pull/12583. This is causing the sklearn-dev tests to fail in #221.Here's the documentation for the new attribute:
Here's the message from the sklearn-dev tests on #221: