Closed mgeplf closed 1 year ago
I think that's fair. Thanks for the PR!
No problem; thanks for the quick response.
If it can be removed altogether, that works too. IIRC, dask
or distributed
print a banner saying it can be installed if visualization is desired.
If Dask and distributed print a banner, and it is optional for them, it's ok to remove it.
I just checked: distributed doesn't include it in its requirements: https://github.com/dask/distributed/blob/main/pyproject.toml#L28
The dask scheduler prints this message, on startup:
2023-04-05 08:55:35,419 - distributed.http.proxy - INFO - To route to workers diagnostics web server please install jupyter-server-proxy: python -m pip install jupyter-server-proxy
I have pushed a change that removes jupyter-server-proxy completely.
Is it ready to merge then?
Is it ready to merge then?
Yup, I think so.
Thanks so much for the PR!
Thanks so much for the PR!
No problem, thanks for accepting it, and maintaining dask-mpi.
As far as I can tell,
jupyter-server-proxy
is not a needed dependency; however it may be useful for debugging. Since it is an 'extra', it would be nice to make it optional. This way,jupyter
and it's dependencies aren't installed.