Closed mrocklin closed 7 years ago
Yes, all the wrapper classes have been removed. A few reasons:
*SearchCV
classes*SearchCV
classes, we need to generate graphs more complicated than were done by using the wrapper classes. For example, to support error_score
we need to keep track of the error state in the pipeline, something that the wrappers couldn't (and shouldn't imo) do.All this was done in https://github.com/dask/dask-learn/pull/14, if you want to see the commits.
Can you verify that we're still avoiding re-computation of early stages in a pipeline? Quick performance tests seem to suggest this.
Yes. Both Pipeline and FeatureUnion are broke into components, and duplicate computations aren't repeated.
The Pipeline class seems to have disappeared. Are we now just introspecting sklearn pipelines to avoid recomputations of earlier stages?