search

dask / dask-searchcv

dask-searchcv is now part of dask-ml: https://github.com/dask/dask-ml
BSD 3-Clause "New" or "Revised" License
240 stars 43 forks source link

ignores extra parameters that are not implemented, like n_jobs #35

Closed alvarouc closed 7 years ago

alvarouc commented 7 years ago

Ignoring n_jobs helps with compatibility while porting code from sklearn to dask-learn

jcrist commented 7 years ago

Sorry for the long wait here. I'm actually slightly against this, as I'd rather not silently ignore misspelled parameters (e.g. eror_score) or parameters we don't yet support (e.g. verbose). I've experienced bugs in the past that were difficult to diagnose because of behavior like this. The same could be accomplished in your code with a small branch:

if use_dask_grid_search:
    est = DaskGridSearchCV(model, grid, **params)
else:
    est = GridSearchCV(model, grid, n_jobs=4, **params)
alvarouc commented 7 years ago

Totally understand your concern. I tend to prefer portability but that its totally up to you.

jcrist commented 7 years ago

n_jobs is now supported in the recent release.