search

dask / dask-searchcv

dask-searchcv is now part of dask-ml: https://github.com/dask/dask-ml
BSD 3-Clause "New" or "Revised" License
240 stars 43 forks source link

Compatibility with scikit-learn 0.19 #54

Closed jimmywan closed 7 years ago

jimmywan commented 7 years ago

Does dask-searchcv work with scikit-learn 0.19+? Getting the following error

  File "/home/vagrant/.pyenv/versions/miniconda3-4.1.11/envs/gambit/lib/python3.6/site-packages/dask_searchcv/methods.py", line 16, in <module>
    from sklearn.utils.fixes import rankdata
ImportError: cannot import name 'rankdata'
jcrist commented 7 years ago

This was fixed in #53. Can you install from master?

pip install git+https://github.com/dask/dask-searchcv.git

I'll probably push a release in the next few days.

TomAugspurger commented 7 years ago

Although it looks like we use sklearn.utils.fixes.in1d in https://github.com/dask/dask-searchcv/blob/63e450d0ae61078ef89297ccdcf0a2d90e9d4430/dask_searchcv/tests/test_model_selection_sklearn.py#L32, which was also remove

jcrist commented 7 years ago

That's just a test, but good catch, will fix.

jcrist commented 7 years ago

That's just a test, but good catch, will fix.

Fixed in #55. I plan to release sometime later this week.

jimmywan commented 7 years ago

Thanks @jcrist . Fixes seem to allow execution again. ~Still running into #28 though. Commented over there since my error seems to be the same as pre scikit-learn 0.19.~ My pipeline seems to start execute, but can't reliably finish. Documented in #57 Not sure if those problems are directly related to scikit-learn 0.19, as I had intermittent trouble under scikit-learn 0.18 as well.

jcrist commented 7 years ago

Just released dask-searchcv version 0.1.0, which is compatible with scikit-learn 0.19.0. Available on pypi and conda-forge.

I think this issue can be closed now, feel free to reopen/open a new issue if you continue to have problems.