mrocklin
commented
4 years ago Thank you for maintaining nbsphinx @mgeier , and for giving us special consideration. Is there anything that we should know about these changes or do here?
Closed mgeier closed 4 years ago
mrocklin
commented
4 years ago Thank you for maintaining nbsphinx @mgeier , and for giving us special consideration. Is there anything that we should know about these changes or do here?
mgeier
commented
4 years ago It would be great if you could have a look at the additional CSS to see if it looks reasonable to you.
I think the main visible change is that after the change there will be more space after code cells and before the following paragraph of text.
mrocklin
commented
4 years ago I would be happy to take a look, but I'll admit that my experience with CSS is not great, so I may not be able to quickly determine what is going on. In general I'm inclined to trust your judgment here.
mgeier
commented
4 years ago I don't think this change is problematic, but it would not hurt if you just had a quick look at the CSS to see if anything looks fishy to you.
mrocklin
commented
4 years ago Nothing looks fishy to me, but that's mostly because I don't understand most of it :)
On Tue, Mar 24, 2020 at 9:57 AM Matthias Geier notifications@github.com wrote:
I don't think this change is problematic, but it would not hurt if you just had a quick look at the CSS to see if anything looks fishy to you.
— You are receiving this because you commented. Reply to this email directly, view it on GitHub https://github.com/dask/dask-sphinx-theme/issues/36#issuecomment-603368352, or unsubscribe https://github.com/notifications/unsubscribe-auth/AACKZTCEC3PMIIDAPP5RDCDRJDRAXANCNFSM4LQPPX4Q .
mgeier
commented
4 years ago OK, thanks for looking!
I've just merged the PR.
After the next release we will see whether there are any complaints.
If there are, please let me know.
BTW, this is how the nbsphinx docs look with the dask theme: https://nbsphinx.readthedocs.io/en/dask-theme/
mrocklin
commented
4 years ago Oh interesting. Are you aware of https://examples.dask.org/array.html ?
On Tue, Mar 24, 2020 at 11:38 AM Matthias Geier notifications@github.com wrote:
OK, thanks for looking!
I've just merged the PR.
After the next release we will see whether there are any complaints.
If there are, please let me know.
BTW, this is how the nbsphinx docs look with the dask theme: https://nbsphinx.readthedocs.io/en/dask-theme/
— You are receiving this because you commented. Reply to this email directly, view it on GitHub https://github.com/dask/dask-sphinx-theme/issues/36#issuecomment-603435817, or unsubscribe https://github.com/notifications/unsubscribe-auth/AACKZTBZEPCNEYX24NKQVALRJD4ZXANCNFSM4LQPPX4Q .
mrocklin
commented
4 years ago We use nbsphinx extensively there
On Tue, Mar 24, 2020 at 11:40 AM Matthew Rocklin mrocklin@gmail.com wrote:
Oh interesting. Are you aware of https://examples.dask.org/array.html ?
On Tue, Mar 24, 2020 at 11:38 AM Matthias Geier notifications@github.com wrote:
OK, thanks for looking!
I've just merged the PR.
After the next release we will see whether there are any complaints.
If there are, please let me know.
BTW, this is how the nbsphinx docs look with the dask theme: https://nbsphinx.readthedocs.io/en/dask-theme/
— You are receiving this because you commented. Reply to this email directly, view it on GitHub https://github.com/dask/dask-sphinx-theme/issues/36#issuecomment-603435817, or unsubscribe https://github.com/notifications/unsubscribe-auth/AACKZTBZEPCNEYX24NKQVALRJD4ZXANCNFSM4LQPPX4Q .
mgeier
commented
4 years ago I've heard about it, but I haven't used it myself. Cool stuff!
This isn't actually an issue (at least I hope not), I just wanted to give y'all a heads up:
I'm planning to add some CSS fixes to
nbsphinxwhen the dask theme is used: https://github.com/spatialaudio/nbsphinx/pull/415I think some of those fixes are already included in the dask theme, but my change hopefully doesn't hurt them.
If you have concerns, suggestions for improvements or any other comments, please let me know!