search

dask / dask-sphinx-theme

Sphinx theme for Dask documentation
BSD 3-Clause "New" or "Revised" License
6 stars 15 forks source link

Odd symbols coming up #47

Closed mrocklin closed 3 years ago

mrocklin commented 3 years ago

Note the text Dask in the upper left, as well as the quotes around "Big Data" (although did someone else already report this?) image

jrbourbeau commented 3 years ago

Hmm that's unfortunate, thanks for reporting @mrocklin...I'm not sure what's causing this yet. Also cc @gforsyth for visibility

although did someone else already report this?

@jsignell reported this over in https://github.com/dask/dask/issues/6704. From what I can tell this issue doesn't appear on Firefox but does on Chrome (at least those are the two browsers I've tested on)

gforsyth commented 3 years ago

Sorry for the trouble. I think this is (somehow) related to "smartquotes".

Annoyingly I can't get the symbols to show up locally (although I can see them on dask.org using Chrome or other chromium-based browsers).

A possible quick fix is to try disabling smartquotes altogether and see if it also fixes the weird rendering issue by the little "home" icon that's currently showing up as i-umlaut euro-cent

jrbourbeau commented 3 years ago

With @gforsyth's PR https://github.com/dask/dask-sphinx-theme/pull/48 the symbols associated with quotes are fixed

Screen Shot 2020-10-05 at 5 14 44 PM

But we're still getting a weird symbol next to "Dask" above the search bar (it should be a little house). But hey, progress!

gforsyth commented 3 years ago

And all of a sudden it's fixed...?

jrbourbeau commented 3 years ago

Closing as this seems to have fixed itself 🎉