search

dask / dask-sphinx-theme

Sphinx theme for Dask documentation
BSD 3-Clause "New" or "Revised" License
6 stars 15 forks source link

Remove bits from layout that should be inherited from RTD #48

Closed gforsyth closed 3 years ago

gforsyth commented 3 years ago

I'm not sure if this will fix the font issues on dask.org but I think it will rule out some potential issues.

I thought I had removed the stuff that Jacob had to add in to fix the flicker-on-load issue, but a closer look shows me there's a bunch of extra stuff we probably don't need in our layout.html so I've removed that here.

@jrbourbeau if this looks ok to you we can try to merge and see if it fixes things.

gforsyth commented 3 years ago

Just got my own understanding, it looks like we're removing code that we're now inheriting from sphinx-rtd-theme?

That's my intention and I can also build the docs cleanly locally with this version (but I also can't reproduce the Chrome stuff locally)

jsignell commented 3 years ago

Nice!