search

dask / dask-sphinx-theme

Sphinx theme for Dask documentation
BSD 3-Clause "New" or "Revised" License
6 stars 15 forks source link

Remove dask logo background? #59

Open gjoseph92 opened 2 years ago

gjoseph92 commented 2 years ago

Just opening for discussion. Personally, I find the dask logo "wallpaper" on the right side of the page a little distracting, and I'd prefer a visually cleaner look with no background. Just curious if others feel the same way, or if we like having the branding.

jacobtomlinson commented 2 years ago

I added the logo texture when we recently redid the theme to visually fill the empty space on larger monitors. I experimented a bunch with stretching content across wider monitors and also centrally aligning it and neither worked well. It needs something on the right to break up all that white space.

Perhaps rather than removing (😢) it would make sense to drop the opacity even further?

gjoseph92 commented 2 years ago

Just for comparison, here are some other docs pages on my widescreen monitor:

Screen Shot 2021-10-14 at 12 44 56 PM Screen Shot 2021-10-14 at 12 44 13 PM Screen Shot 2021-10-14 at 12 44 38 PM Screen Shot 2021-10-14 at 12 45 11 PM

I'll say that I like the centered ones a lot more. The Python docs stand out here as being much less readable, since they're shifted all the way to the left of my screen, and that blank space to the right is awkward.

For comparison, here's dask full-width: Screen Shot 2021-10-14 at 12 46 19 PM A bit too wide for my taste? Kinda hard to read when the lines are so long. This is probably because the .container-xl's max-width is a percentage, not a fixed upper bound for the largest @media. And without the logo texture (doesn't make a ton of difference, though a slightly cleaner look): Screen Shot 2021-10-14 at 12 46 33 PM

What I think does make a big difference is centering. Obviously this doesn't look great because of the black sidebar: Screen Shot 2021-10-14 at 12 54 38 PM

But if we're willing to change that branding (which incidentally might make a dark-mode theme easier in the future), I think it looks nice: Screen Shot 2021-10-14 at 12 53 50 PM

And centered, the logo texture stands out a bit more. Without it, I feel like it has a cleaner, less busy look: Screen Shot 2021-10-14 at 12 53 39 PM

Making the left side match the sidebar color (like in pip's docs) is maybe a nice touch? Or it draws attention to the empty space. I can't really decide. Screen Shot 2021-10-14 at 1 01 03 PM

jacobtomlinson commented 2 years ago

Thanks for the efforts here @gjoseph92. I don't have an ultrawide to test on (and honestly I assumed folks with ultrawides never full-screen things anyway).

I think you're right that the max width is a little large.

Your last screenshot is looking nice. Perhaps you could make the sidebar text black as the orange doesn't have enough contrast on that black background. And the nav needs centering too. But maybe you could raise a PR with those changes?

(Still kinda sad to lose the texture on the right though, I quite liked it)

jacobtomlinson commented 2 years ago

@gjoseph92 do you intend on finishing this up?