search

dask / dask-sphinx-theme

Sphinx theme for Dask documentation
BSD 3-Clause "New" or "Revised" License
6 stars 15 forks source link

Colors! #76

Open mrocklin opened 2 years ago

mrocklin commented 2 years ago

Thanks all for the work on the sphinx theme. I'm curious about how we're choosing colors here. For example in our configuration reference I'm seeing the following:

image

Are these intentional (from a pallete somewhere?) or are we just deferring to the underlying theme? If the latter, should I just make modifications as I see fit, or do we want to consult something grander (if anyone else wants to take this away from me I'd be happy for it)

jrbourbeau commented 2 years ago

I think colors are intentional and coming from https://www.dask.org/brand-guide (though maybe we haven't gotten to updating colors in all parts of the theme yet)

cc @scharlottej13 as she'll know more about this

mrocklin commented 2 years ago

I don't know. That background blue looks awfully like standard Sphinx. My experience doing Sphinx style guide stuff is that there are a lot of little settings you don't catch the first time around.

mrocklin commented 2 years ago

(or at least, I failed at finding everything the first few times I did this)

scharlottej13 commented 2 years ago

I think colors are intentional and coming from https://www.dask.org/brand-guide (though maybe we haven't gotten to updating colors in all parts of the theme yet)

Yes, exactly! I met w/ Jeromy and he also sent me these additional style guides: Dask-Doc Portal Spec Sheet.pdf Dask-Doc Portal mockup.pdf

I don't know. That background blue looks awfully like standard Sphinx. My experience doing Sphinx style guide stuff is that there are a lot of little settings you don't catch the first time around.

Yup, spot on :). I went through and tried to find how to change most things, but I'm sure there were a bunch of little things I missed. I would be happy for you or others to jump in and make modifications. I outlined a couple outstanding items in #67 too and then there's a heated discussion on footer background colors in #75.

scharlottej13 commented 1 year ago

some options inspired by the spec sheet and discussion w/ @mrdanjlund77

option 1: black/light grey/slightly darker light grey

Screen Shot 2023-04-06 at 3 52 56 PM

option 2: dark blue/slightly darker light grey

Screen Shot 2023-04-06 at 4 02 45 PM

option 3: dark blue text, light blue background + light grey background

Screen Shot 2023-04-06 at 4 37 54 PM

jrbourbeau commented 1 year ago

Nice!

My personal ranking would be (in order of decreasing preference)

@jacobtomlinson I'd be curious if you have any thoughts here

jacobtomlinson commented 1 year ago

Yup I agree with that ranking.