search

dask / dask-tutorial

Dask tutorial
https://tutorial.dask.org
BSD 3-Clause "New" or "Revised" License
1.83k stars 708 forks source link

Pin jupyterlab #131

Closed JarnoRFB closed 5 years ago

JarnoRFB commented 5 years ago

That makes ipywidgets work on binder.

JarnoRFB commented 5 years ago

I checked that it works on binder this time.

TomAugspurger commented 5 years ago

Do you know why this is needed?

JarnoRFB commented 5 years ago

Seems to be an issue with ipywidgets. The current version 7.5, does not seem to work with jupyter lab 0.34 which is deployed on binder. So one could remove this, once binder updates jupyter lab.

TomAugspurger commented 5 years ago

In dask-examples, we include jupyterlab in the binder/environment.yaml: https://github.com/dask/dask-examples/blob/master/binder/environment.yml#L9

Can we do the same here?

On Mon, Oct 14, 2019 at 7:23 AM Rüdiger Busche notifications@github.com wrote:

Seems to be an issue with ipywidgets. The current version 7.5, does not seem to work with jupyter lab 0.34 which is deployed on binder. So one could remove this, once binder updates jupyter lab.

— You are receiving this because you commented. Reply to this email directly, view it on GitHub https://github.com/dask/dask-tutorial/pull/131?email_source=notifications&email_token=AAKAOIU5TDBRM2NY6V4JVJDQORQDZA5CNFSM4I7PIT3KYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEBEN2WY#issuecomment-541646171, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAKAOIW2PSA3ZYPZBGTNZXDQORQDZANCNFSM4I7PIT3A .

JarnoRFB commented 5 years ago

yeah that works. Thanks for the suggestion!

TomAugspurger commented 5 years ago

Thanks!